Skip to content

Commit 9766cb6

Browse files
authored
chore: extra code removals before 1.0 (#2421)
Alternatives have existed for a long time and we just ensure that we remove before the 1.0 release. Summary: - remove pip_install_dependencies - remove DEFAULT_PYTHON_VERSION from interpreters.bzl Work towards #1361
1 parent e7c306d commit 9766cb6

File tree

6 files changed

+6
-42
lines changed

6 files changed

+6
-42
lines changed

CHANGELOG.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,10 @@ Other changes:
9797

9898
{#v0-0-0-removed}
9999
### Removed
100-
* Nothing removed.
100+
* (pypi): Remove `pypi_install_dependencies` macro that has been included in
101+
{bzl:obj}`py_repositories` for a long time.
102+
* (bzlmod): Remove `DEFAULT_PYTHON_VERSION` from `interpreters.bzl` file. If
103+
you need the version, please use it from the `versions.bzl` file instead.
101104

102105
{#v0-40-0}
103106
## [0.40.0] - 2024-11-17

examples/bzlmod/MODULE.bazel.lock

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

python/pip_install/BUILD.bazel

-8
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,6 @@ bzl_library(
3535
deps = ["//python/private/pypi:pip_compile_bzl"],
3636
)
3737

38-
bzl_library(
39-
name = "repositories_bzl",
40-
srcs = ["repositories.bzl"],
41-
deps = [
42-
"//python/private/pypi:deps_bzl",
43-
],
44-
)
45-
4638
filegroup(
4739
name = "distribution",
4840
srcs = glob(["**"]),

python/pip_install/repositories.bzl

-19
This file was deleted.

python/private/pythons_hub.bzl

-3
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ _interpreters_bzl_template = """
8686
INTERPRETER_LABELS = {{
8787
{interpreter_labels}
8888
}}
89-
DEFAULT_PYTHON_VERSION = "{default_python_version}"
9089
"""
9190

9291
_line_for_hub_template = """\
@@ -125,8 +124,6 @@ def _hub_repo_impl(rctx):
125124
rctx.file(
126125
"interpreters.bzl",
127126
_interpreters_bzl_template.format(
128-
# TODO @aignas 2024-09-28: before 1.0 remove the value from here
129-
default_python_version = rctx.attr.default_python_version,
130127
interpreter_labels = interpreter_labels,
131128
),
132129
executable = False,

tests/integration/pip_parse/WORKSPACE

-9
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,6 @@ load("@rules_python//python:repositories.bzl", "py_repositories", "python_regist
77

88
py_repositories()
99

10-
# This call is included in `py_repositories` and we are calling
11-
# `pip_install_dependencies` only to ensure that we are not breaking really old
12-
# code.
13-
#
14-
# TODO @aignas 2024-06-23: remove this before 1.0.0
15-
load("@rules_python//python/pip_install:repositories.bzl", "pip_install_dependencies")
16-
17-
pip_install_dependencies()
18-
1910
python_register_toolchains(
2011
name = "python39",
2112
python_version = "3.9",

0 commit comments

Comments
 (0)