New xcframework_excluded_platforms option to help remove slices to compile as needed #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpile in xcframework
also rubocop and other minor fixes
… latest rules_ios
gyfelton
force-pushed
the
new-xcframework-exclude-platform-option
branch
from
38e7eb3 to
5ab5b9a
Compare
gyfelton
changed the title
dnkoutso
approved these changes
May 15, 2025
thiagohmcruz
approved these changes
May 15, 2025
Comment on lines
+43
to
+44
| # TODO: add back integration once we can fix its dep on rules_ios | ||
| task spec: %w[spec:unit] |
Contributor
There was a problem hiding this comment.
What is the issue with the integration tests? I was about to suggest adding a test for this (i.e. something that exercises excluding one platform) but IIUC we're disabling such tests in this PR. Is that correct?
If that's the case can you file an issue and link the issue here so there's more context to fix this in a follow up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New config to help downstream project exclude slices from xcframework to reduce # of targets to build.
Right now rules_ios don't support visionos so need to remove it.
also update CI to make job green gain. Removed integration test that we should fix later if needed.
Specify ruby version to 2.7 as a test gem called bacon does not seem to support ruby v3 anymore