Skip to content

Add boost 1.88.0 Level 0 libraries #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 32 commits into from

Conversation

Vertexwahn
Copy link
Contributor

@Vertexwahn Vertexwahn commented Jul 13, 2025

This PR brings Level 0 libraries of Boost 1.88.0 to BCR - see https://pdimov.github.io/boostdep-report/boost-1.88.0/module-levels.html

In particular:

  • boost.config
  • boost.mp11
  • boost.pfr
  • boost.predef
  • boost.preprocessor
  • boost.qvm
  • boost.hof 🆕
  • boost.lambda2 🆕
  • boost.callable_traits 🆕

Currently not in this PR, since there are test dependencies to missing things:

  • boost.crc
  • boost.ratio

Currently not supported by BCR:

  • boost.headers

@Vertexwahn Vertexwahn marked this pull request as draft July 13, 2025 21:55
@bazel-io
Copy link
Member

Hello @wep21, modules you maintain (boost.config) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@Vertexwahn
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Jul 13, 2025
@Vertexwahn Vertexwahn changed the title Add boost.config 1.88.0.bcr1 Add boost 1.88.0 Level 0 deps Jul 13, 2025
@bazel-io
Copy link
Member

Hello @wep21, modules you maintain (boost.config, boost.mp11) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@Vertexwahn
Copy link
Contributor Author

@bazel-io skip_check compatibility_level

@bazel-io bazel-io added the skip-compatibility-level-check Skip the compatibility_level check for MODULE.bazel label Jul 13, 2025
@bazel-io
Copy link
Member

Hello @wep21, modules you maintain (boost.config, boost.mp11, boost.qvm) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io
Copy link
Member

Hello @wep21, modules you maintain (boost.config, boost.mp11, boost.predef, boost.qvm) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io
Copy link
Member

Hello @wep21, modules you maintain (boost.config, boost.mp11, boost.predef, boost.preprocessor, boost.qvm) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io
Copy link
Member

Hello @wep21, modules you maintain (boost.config, boost.mp11, boost.pfr, boost.predef, boost.preprocessor, boost.qvm) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@Vertexwahn
Copy link
Contributor Author

@arvid-norlander Can you check for any differences between your PR and this one - if you agree I would merge this PR if you are fine with it...

@Vertexwahn Vertexwahn changed the title Add boost 1.88.0 Level 0 deps Add boost 1.88.0 Level 0 libraries Jul 13, 2025
@arvid-norlander
Copy link

arvid-norlander commented Jul 14, 2025

Shouldn't there be changes to boost.pin_version too to add numeric_interval and numeric_ublas to the list?

Other than that, it is perhaps sensible to do this a bit at a time like this.

@Vertexwahn
Copy link
Contributor Author

Shouldn't there be changes to boost.pin_version too to add numeric_interval and numeric_ublas to the list?

Other than that, it is perhaps sensible to do this a bit at a time like this.

@arvid-norlander Yes. This is already merged: #5145

@Vertexwahn
Copy link
Contributor Author

Vertexwahn commented Jul 14, 2025

@arvid-norlander If you approve this PR, I will change it from "Draft" to "Ready to Review" (and I guess it will then be merged automatically) - we can then proceed with Level 1 libs (either you or I can then create a PR for this)

@Vertexwahn Vertexwahn requested a review from wep21 July 15, 2025 18:58
@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (boost.hof, boost.lambda2) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (boost.callable_traits, boost.hof, boost.lambda2) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jul 15, 2025
Wyverald
Wyverald previously approved these changes Jul 15, 2025
@bazel-io bazel-io dismissed Wyverald’s stale review July 15, 2025 20:15

Require module maintainers' approval for newly pushed changes.

bazel-io
bazel-io previously approved these changes Jul 15, 2025
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@bazel-io bazel-io dismissed their stale review July 15, 2025 20:40

Require module maintainers' approval for newly pushed changes.

bazel-io
bazel-io previously approved these changes Jul 15, 2025
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@Vertexwahn
Copy link
Contributor Author

Vertexwahn commented Jul 15, 2025

@Wyverald Seems CI is flaky... or Maybe my in between merge destroyed something - will copy over my changes to smaller PRs...

@bazel-io bazel-io dismissed their stale review July 15, 2025 20:59

Require module maintainers' approval for newly pushed changes.

@Vertexwahn Vertexwahn closed this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-compatibility-level-check Skip the compatibility_level check for MODULE.bazel skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants