Skip to content

Add [email protected] #5154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 15, 2025
Merged

Add [email protected] #5154

merged 10 commits into from
Jul 15, 2025

Conversation

kgreenek
Copy link
Contributor

No description provided.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (behaviortree_cpp) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@kgreenek
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Jul 14, 2025
@kgreenek
Copy link
Contributor Author

Ready for bcr-presubmit

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jul 15, 2025
meteorcloudy
meteorcloudy previously approved these changes Jul 15, 2025
View reviewed changes
@bazel-io bazel-io dismissed meteorcloudy’s stale review July 15, 2025 17:25

Require module maintainers' approval for newly pushed changes.

@kgreenek
Copy link
Contributor Author

@bazel-io skip_check incompatible_flags

@bazel-io bazel-io added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label Jul 15, 2025
@kgreenek
Copy link
Contributor Author

PTAL all checks passing.

I had to disable CI checks for rolling because of some toolchain errors like this:

Unable to find package for @@[unknown repo 'local_config_platform'

If you happen to know if that's easily resolved I'd be grateful. Otherwise I'm fine merging without rolling support for now.

@kgreenek kgreenek requested a review from meteorcloudy July 15, 2025 18:29
@Wyverald
Copy link
Member

For the rolling release error, you just need to upgrade to a newer release of aspect_bazel_lib. But it's also fine to do that in a future version.

@Wyverald Wyverald merged commit 0531859 into bazelbuild:main Jul 15, 2025
12 checks passed
@kgreenek kgreenek deleted the kgk/behaviortree-cpp branch July 15, 2025 21:09
@kgreenek
Copy link
Contributor Author

For the rolling release error, you just need to upgrade to a newer release of aspect_bazel_lib. But it's also fine to do that in a future version.

Got it! Good to know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

@meteorcloudy meteorcloudy Awaiting requested review from meteorcloudy

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kgreenek @bazel-io @Wyverald @meteorcloudy