Skip to content

Commit ffd150b

Browse files
committed
Fix more tests
1 parent 18048ba commit ffd150b

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

apple/internal/bundling_support.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,15 +363,15 @@ Please file an issue on the Apple BUILD Rules.
363363
if _path_is_under_fragments(path, formatted_path_fragments) != allow_path_under_fragments:
364364
sets.insert(bad_paths, path)
365365

366-
if len(bad_paths):
366+
if sets.length(bad_paths):
367367
if not message:
368368
message_prefix = (
369369
"Expected only " if allow_path_under_fragments else "Did not expect any "
370370
)
371371
as_path = "*" + "*".join(formatted_path_fragments) + "..."
372372
message = message_prefix + "files inside directories named '*.%s'" % (as_path)
373373

374-
formatted_paths = "[\n %s\n]" % ",\n ".join(bad_paths)
374+
formatted_paths = "[\n %s\n]" % ",\n ".join(sets.to_list(bad_paths))
375375
fail("%s, but found the following: %s" % (message, formatted_paths))
376376

377377
def _validate_bundle_id(bundle_id):

test/starlark_tests/ios_application_resources_test.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ Found the following legacy .appiconset files: """,
281281
Found Icon Composer .icon bundles among the assigned app_icons. These are only supported on Xcode 26 or later.""",
282282
tags = [
283283
name,
284-
],
284+
] + common.skip_ci_tags,
285285
)
286286

287287
# Tests that the launch storyboard is bundled with the application and that

test/starlark_tests/ios_dynamic_framework_tests.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def ios_dynamic_framework_test_suite(name):
6868
"DTSDKName": "iphone*",
6969
"DTXcode": "*",
7070
"DTXcodeBuild": "*",
71-
"MinimumOSVersion": "13.0",
71+
"MinimumOSVersion": "12.0",
7272
"UIDeviceFamily:0": "1",
7373
},
7474
tags = [name],

0 commit comments

Comments
 (0)