Skip to content

Conversation

@adincebic
Copy link
Contributor

(cherry picked from commit 5557de8c0697fe3a9cb83214a7cce2357a355f3e

…talog has no assets to compile.

PiperOrigin-RevId: 819717389
(cherry picked from commit 5557de8)
Copy link
Contributor

@aaronsky aaronsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully this doesn't make cherry picking earlier commits more difficult

Copy link
Contributor

@aaronsky aaronsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no, we shouldn't take this until other commits affecting actool from this past summer are in. asset_files gets clobbered in this implementation by lines that are not present upstream

@adincebic
Copy link
Contributor Author

actually no, we shouldn't take this until other commits affecting actool from this past summer are in. asset_files gets clobbered in this implementation by lines that are not present upstream

Alright, I'll make it a draft until we cherry pick stuff from the list of commits you shared.


# Separate alternate icons from regular assets
alternate_icons = []
asset_files = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably still want to make sure this isn't overriding the above, since we've deviated a bit from the cherry pick

@aaronsky aaronsky self-requested a review November 13, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants