Skip to content

Migrate ObjcInfo to rules_cc #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Migrate ObjcInfo to rules_cc #2811

wants to merge 4 commits into from
+42 −25

Conversation

@keith
Copy link
Member

@keith keith commented Nov 11, 2025

Using #2801 as a starting
point

@aaronsky
Copy link
Contributor

aaronsky commented Nov 11, 2025 •
edited
Loading

looks like _cc_internal.create_header_info() was added in bazelbuild/bazel@748f11c, which post-dates our "last_green" pin of bazelbuild/bazel@5409637 by about a month. this might start working if we can move that pin forward again

@keith keith force-pushed the ks/migrate-objcinfo-to-rules_cc branch from c5449c5 to 9d82827 Compare November 11, 2025 20:44
@keith
Copy link
Member Author

keith commented Nov 12, 2025

not sure i want to merge this since it actually breaks more than it fixes until we fix other rules_cc compat issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronsky aaronsky aaronsky approved these changes

@adincebic adincebic Awaiting requested review from adincebic adincebic will be requested when the pull request is marked ready for review adincebic is a code owner

@brentleyjones brentleyjones Awaiting requested review from brentleyjones brentleyjones will be requested when the pull request is marked ready for review brentleyjones is a code owner

@luispadron luispadron Awaiting requested review from luispadron luispadron will be requested when the pull request is marked ready for review luispadron is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob will be requested when the pull request is marked ready for review mattrobmattrob is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@keith @aaronsky