Skip to content

Commit 9848937

Browse files
committed
Bump dependencies
- Update bazel_skylib to 1.8.2 - Update rules_java to 9.3.0 - Update bazel_features to 1.37.0 - Update protobuf to 33.1 - Update rules_jvm_external to 6.9 - Update rules_cc to 0.2.14
1 parent 5ea3a9b commit 9848937

File tree

16 files changed

+172
-130
lines changed

16 files changed

+172
-130
lines changed

MODULE.bazel

Lines changed: 21 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,23 @@ proto_version_parts = proto_version.split(".")
1111

1212
proto_module_version = ".".join(proto_version_parts[-2:]) # Last 2 parts
1313

14-
bazel_dep(name = "protobuf", version = proto_module_version, repo_name = "com_google_protobuf")
15-
bazel_dep(name = "rules_proto", version = "6.0.2", repo_name = "rules_proto")
16-
bazel_dep(name = "abseil-py", version = "2.1.0", repo_name = "py_absl")
17-
bazel_dep(name = "rules_cc", version = "0.0.16")
18-
bazel_dep(name = "platforms", version = "0.0.11")
14+
bazel_dep(name = "platforms", version = "1.0.0")
1915
bazel_dep(name = "bazel_skylib", version = "1.8.2")
20-
bazel_dep(name = "rules_java", version = "8.9.0")
21-
bazel_dep(name = "rules_python", version = "0.23.1")
16+
bazel_dep(name = "rules_java", version = "9.3.0")
2217
bazel_dep(name = "rules_android", version = "0.6.6")
18+
bazel_dep(name = "bazel_features", version = "1.37.0")
19+
bazel_dep(name = "protobuf", version = proto_module_version, repo_name = "com_google_protobuf")
20+
bazel_dep(name = "abseil-py", version = "2.1.0", repo_name = "py_absl")
21+
bazel_dep(name = "rules_cc", version = "0.2.14")
22+
bazel_dep(name = "bazel_worker_api", version = "0.0.8")
23+
bazel_dep(name = "bazel_worker_java", version = "0.0.8")
24+
25+
# End of dependencies shared with MODULE.release.bazel
26+
bazel_dep(name = "rules_python", version = "1.6.0", dev_dependency = True)
27+
bazel_dep(name = "rules_shell", version = "0.6.1", dev_dependency = True)
28+
29+
# TODO[https://github.com/bazelbuild/rules_kotlin/issues/1395]: Update when fixed version is available.
30+
bazel_dep(name = "buildifier_prebuilt", version = "8.2.1.1", dev_dependency = True)
2331

2432
remote_android_extensions = use_extension(
2533
"@rules_android//bzlmod_extensions:android_extensions.bzl",
@@ -32,14 +40,6 @@ use_repo(android_sdk_repository_extension, "androidsdk")
3240

3341
register_toolchains("@androidsdk//:all")
3442

35-
bazel_dep(name = "bazel_features", version = "1.25.0")
36-
bazel_dep(name = "rules_shell", version = "0.4.1")
37-
bazel_dep(name = "bazel_worker_api", version = "0.0.8")
38-
bazel_dep(name = "bazel_worker_java", version = "0.0.8")
39-
40-
# TODO[https://github.com/bazelbuild/rules_kotlin/issues/1395]: Update when fixed version is available.
41-
bazel_dep(name = "buildifier_prebuilt", version = "8.2.1", dev_dependency = True)
42-
4343
rules_java_toolchains = use_extension("@rules_java//java:extensions.bzl", "toolchains")
4444
use_repo(rules_java_toolchains, "remote_java_tools")
4545

@@ -62,11 +62,8 @@ register_toolchains("//src/main/starlark/core/compile/cli")
6262
register_toolchains("//kotlin/internal:default_toolchain")
6363

6464
# Development dependencies
65-
# TODO(bencodes) A bunch of these dependencies need to be marked as dev_dependencies but before we can do that
66-
# we need to sort out a few cases around how these rules are consumed in various ways.
67-
68-
bazel_dep(name = "rules_jvm_external", version = "6.6")
69-
bazel_dep(name = "bazel_ci_rules", version = "1.0.0")
65+
bazel_dep(name = "rules_jvm_external", version = "6.9", dev_dependency = True)
66+
bazel_dep(name = "bazel_ci_rules", version = "1.0.0", dev_dependency = True)
7067

7168
rbe_preconfig = use_repo_rule("@bazel_ci_rules//:rbe_repo.bzl", "rbe_preconfig")
7269

@@ -131,19 +128,18 @@ maven.override(
131128
)
132129
use_repo(maven, "kotlin_rules_maven", "unpinned_kotlin_rules_maven")
133130

134-
bazel_dep(name = "rules_pkg", version = "1.0.1")
135-
bazel_dep(name = "stardoc", version = "0.8.0", repo_name = "io_bazel_stardoc")
136-
131+
bazel_dep(name = "rules_pkg", version = "1.1.0", dev_dependency = True)
132+
bazel_dep(name = "stardoc", version = "0.8.0", dev_dependency = True, repo_name = "io_bazel_stardoc")
137133
bazel_dep(name = "rules_testing", version = "0.9.0", dev_dependency = True)
138134
bazel_dep(name = "rules_bazel_integration_test", version = "0.34.0", dev_dependency = True)
139135

140136
bazel_binaries = use_extension("@rules_bazel_integration_test//:extensions.bzl", "bazel_binaries", dev_dependency = True)
141137
bazel_binaries.download(version_file = "//:.bazelversion")
142-
bazel_binaries.download(version = "8.2.1")
138+
bazel_binaries.download(version = "8.4.2")
143139
use_repo(
144140
bazel_binaries,
145141
"bazel_binaries",
146142
"bazel_binaries_bazelisk",
147143
"build_bazel_bazel_.bazelversion",
148-
"build_bazel_bazel_8_2_1",
144+
"build_bazel_bazel_8_4_2",
149145
)

MODULE.release.bazel

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,20 @@ module(
55
repo_name = "rules_kotlin",
66
)
77

8-
bazel_dep(name = "platforms", version = "0.0.11")
9-
bazel_dep(name = "bazel_skylib", version = "1.7.1")
10-
bazel_dep(name = "rules_java", version = "8.9.0")
11-
bazel_dep(name = "rules_android", version = "0.6.4")
12-
bazel_dep(name = "bazel_features", version = "1.25.0")
13-
bazel_dep(name = "protobuf", version = "29.0", repo_name = "com_google_protobuf")
14-
bazel_dep(name = "rules_proto", version = "6.0.2", repo_name = "rules_proto")
8+
proto_version = "4.33.1"
9+
10+
proto_version_parts = proto_version.split(".")
11+
12+
proto_module_version = ".".join(proto_version_parts[-2:]) # Last 2 parts
13+
14+
bazel_dep(name = "platforms", version = "1.0.0")
15+
bazel_dep(name = "bazel_skylib", version = "1.8.2")
16+
bazel_dep(name = "rules_java", version = "9.3.0")
17+
bazel_dep(name = "rules_android", version = "0.6.6")
18+
bazel_dep(name = "bazel_features", version = "1.37.0")
19+
bazel_dep(name = "protobuf", version = proto_module_version, repo_name = "com_google_protobuf")
1520
bazel_dep(name = "abseil-py", version = "2.1.0", repo_name = "py_absl")
16-
bazel_dep(name = "rules_cc", version = "0.0.16")
21+
bazel_dep(name = "rules_cc", version = "0.2.14")
1722
bazel_dep(name = "bazel_worker_api", version = "0.0.8")
1823
bazel_dep(name = "bazel_worker_java", version = "0.0.8")
1924

README.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,22 @@ http_archive(
7777
load("@rules_kotlin//kotlin:repositories.bzl", "kotlin_repositories")
7878
kotlin_repositories() # if you want the default. Otherwise see custom kotlinc distribution below
7979

80+
# Required: Initialize bazel_features (needed by rules_kotlin transitive dependencies)
81+
load("@bazel_features//:deps.bzl", "bazel_features_deps")
82+
bazel_features_deps()
83+
84+
# Required: Initialize protobuf dependencies (creates proto_bazel_features repository
85+
# needed by rules_java's java:defs.bzl)
86+
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
87+
protobuf_deps()
88+
8089
load("@rules_kotlin//kotlin:core.bzl", "kt_register_toolchains")
8190
kt_register_toolchains() # to use the default toolchain, otherwise see toolchains below
8291
```
8392

93+
**Note:** The `bazel_features_deps()` and `protobuf_deps()` calls are required to avoid
94+
WORKSPACE cycle errors with recent versions of rules_java and protobuf.
95+
8496
## `BUILD` files
8597

8698
In your project's `BUILD` files, load the Kotlin rules and use them like so:
@@ -144,6 +156,9 @@ kotlin_repositories(
144156
sha256 = "a118197b0de55ffab2bc8d5cd03a5e39033cfb53383d6931bc761dec0784891a"
145157
)
146158
)
159+
160+
# Don't forget to also call bazel_features_deps() and protobuf_deps() as shown
161+
# in the basic WORKSPACE setup above, followed by kt_register_toolchains()
147162
```
148163

149164
## Third party dependencies
@@ -336,6 +351,9 @@ kotlin_repositories(
336351
sha256 = "2ce5a08fddd20ef07ac051615905453fe08c3ba3ce5afa5dc43a9b77aa64507d",
337352
),
338353
)
354+
355+
# Don't forget to also call bazel_features_deps() and protobuf_deps() as shown
356+
# in the basic WORKSPACE setup above, followed by kt_register_toolchains()
339357
```
340358

341359
# Kotlin compiler plugins

examples/android/.bazelrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
common --lockfile_mode=off
22
test --test_output=all
33
build --config=android_worker
4+
build --cxxopt="--std=c++17"
45

56
# Worker configuration
67
build:android_worker \

examples/android/WORKSPACE

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,20 @@ http_archive(
3737
urls = [url.format(version = versions.BAZEL_SKYLIB.version) for url in versions.BAZEL_SKYLIB.url_templates],
3838
)
3939

40-
# Android rules dependencies
40+
# kotlin_repositories must be called first to set up com_google_protobuf
41+
kotlin_repositories()
42+
43+
load("@bazel_features//:deps.bzl", "bazel_features_deps")
44+
45+
bazel_features_deps()
46+
47+
# protobuf_deps() must be called BEFORE loading from @rules_java
48+
# to create proto_bazel_features repository
49+
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
50+
51+
protobuf_deps()
52+
53+
# Android rules dependencies - must come AFTER protobuf_deps()
4154
load("@rules_android//:prereqs.bzl", "rules_android_prereqs")
4255

4356
rules_android_prereqs()
@@ -47,12 +60,6 @@ load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
4760

4861
rules_java_dependencies()
4962

50-
# note that the following line is what is minimally required from protobuf for the java rules
51-
# consider using the protobuf_deps() public API from @com_google_protobuf//:protobuf_deps.bzl
52-
load("@com_google_protobuf//bazel/private:proto_bazel_features.bzl", "proto_bazel_features") # buildifier: disable=bzl-visibility
53-
54-
proto_bazel_features(name = "proto_bazel_features")
55-
5663
# register toolchains
5764
load("@rules_java//java:repositories.bzl", "rules_java_toolchains")
5865

@@ -82,8 +89,6 @@ register_toolchains(
8289
"@rules_android//toolchains/android_sdk:android_sdk_tools",
8390
)
8491

85-
kotlin_repositories()
86-
8792
load("@rules_kotlin//kotlin:core.bzl", "kt_register_toolchains")
8893

8994
kt_register_toolchains()

examples/anvil/WORKSPACE

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,20 @@ http_archive(
2828
urls = [url.format(version = versions.BAZEL_SKYLIB.version) for url in versions.BAZEL_SKYLIB.url_templates],
2929
)
3030

31-
# Android rules dependencies
31+
# kotlin_repositories must be called first to set up com_google_protobuf
32+
kotlin_repositories()
33+
34+
load("@bazel_features//:deps.bzl", "bazel_features_deps")
35+
36+
bazel_features_deps()
37+
38+
# protobuf_deps() must be called BEFORE loading from @rules_java
39+
# to create proto_bazel_features repository
40+
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
41+
42+
protobuf_deps()
43+
44+
# Android rules dependencies - must come AFTER protobuf_deps()
3245
load("@rules_android//:prereqs.bzl", "rules_android_prereqs")
3346

3447
rules_android_prereqs()
@@ -38,12 +51,6 @@ load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
3851

3952
rules_java_dependencies()
4053

41-
# note that the following line is what is minimally required from protobuf for the java rules
42-
# consider using the protobuf_deps() public API from @com_google_protobuf//:protobuf_deps.bzl
43-
load("@com_google_protobuf//bazel/private:proto_bazel_features.bzl", "proto_bazel_features") # buildifier: disable=bzl-visibility
44-
45-
proto_bazel_features(name = "proto_bazel_features")
46-
4754
# register toolchains
4855
load("@rules_java//java:repositories.bzl", "rules_java_toolchains")
4956

@@ -73,8 +80,6 @@ register_toolchains(
7380
"@rules_android//toolchains/android_sdk:android_sdk_tools",
7481
)
7582

76-
kotlin_repositories()
77-
7883
load("@rules_kotlin//kotlin:core.bzl", "kt_register_toolchains")
7984

8085
kt_register_toolchains()

examples/associates/WORKSPACE

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,21 @@ http_archive(
3030

3131
kotlin_repositories()
3232

33+
load("@bazel_features//:deps.bzl", "bazel_features_deps")
34+
35+
bazel_features_deps()
36+
37+
# protobuf_deps() must be called to create proto_bazel_features repository
38+
# which is needed by rules_java's java:defs.bzl
39+
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
40+
41+
protobuf_deps()
42+
3343
##### rules_java setup for rules_android #####
3444
load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
3545

3646
rules_java_dependencies()
3747

38-
# note that the following line is what is minimally required from protobuf for the java rules
39-
# consider using the protobuf_deps() public API from @com_google_protobuf//:protobuf_deps.bzl
40-
load("@com_google_protobuf//bazel/private:proto_bazel_features.bzl", "proto_bazel_features") # buildifier: disable=bzl-visibility
41-
42-
proto_bazel_features(name = "proto_bazel_features")
43-
4448
# register toolchains
4549
load("@rules_java//java:repositories.bzl", "rules_java_toolchains")
4650

examples/dagger/WORKSPACE

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,21 @@ http_archive(
3030

3131
kotlin_repositories()
3232

33+
load("@bazel_features//:deps.bzl", "bazel_features_deps")
34+
35+
bazel_features_deps()
36+
37+
# protobuf_deps() must be called to create proto_bazel_features repository
38+
# which is needed by rules_java's java:defs.bzl
39+
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
40+
41+
protobuf_deps()
42+
3343
##### rules_java setup for rules_android #####
3444
load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
3545

3646
rules_java_dependencies()
3747

38-
# note that the following line is what is minimally required from protobuf for the java rules
39-
# consider using the protobuf_deps() public API from @com_google_protobuf//:protobuf_deps.bzl
40-
load("@com_google_protobuf//bazel/private:proto_bazel_features.bzl", "proto_bazel_features") # buildifier: disable=bzl-visibility
41-
42-
proto_bazel_features(name = "proto_bazel_features")
43-
4448
# register toolchains
4549
load("@rules_java//java:repositories.bzl", "rules_java_toolchains")
4650

examples/deps/WORKSPACE

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,20 @@ http_archive(
2828
urls = [url.format(version = versions.BAZEL_SKYLIB.version) for url in versions.BAZEL_SKYLIB.url_templates],
2929
)
3030

31-
# Android rules dependencies
31+
# kotlin_repositories must be called first to set up com_google_protobuf
32+
kotlin_repositories()
33+
34+
load("@bazel_features//:deps.bzl", "bazel_features_deps")
35+
36+
bazel_features_deps()
37+
38+
# protobuf_deps() must be called BEFORE loading from @rules_java
39+
# to create proto_bazel_features repository
40+
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
41+
42+
protobuf_deps()
43+
44+
# Android rules dependencies - must come AFTER protobuf_deps()
3245
load("@rules_android//:prereqs.bzl", "rules_android_prereqs")
3346

3447
rules_android_prereqs()
@@ -38,12 +51,6 @@ load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
3851

3952
rules_java_dependencies()
4053

41-
# note that the following line is what is minimally required from protobuf for the java rules
42-
# consider using the protobuf_deps() public API from @com_google_protobuf//:protobuf_deps.bzl
43-
load("@com_google_protobuf//bazel/private:proto_bazel_features.bzl", "proto_bazel_features") # buildifier: disable=bzl-visibility
44-
45-
proto_bazel_features(name = "proto_bazel_features")
46-
4754
# register toolchains
4855
load("@rules_java//java:repositories.bzl", "rules_java_toolchains")
4956

@@ -75,7 +82,9 @@ register_toolchains(
7582
"@rules_android//toolchains/android_sdk:android_sdk_tools",
7683
)
7784

78-
kotlin_repositories()
85+
load("@rules_kotlin//kotlin:core.bzl", "kt_register_toolchains")
86+
87+
kt_register_toolchains()
7988

8089
register_toolchains("//bzl:experimental_toolchain")
8190

examples/multiplex/.bazelrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ build --worker_verbose
22
build --worker_max_instances=1
33
build --worker_quit_after_build
44
build --profile=/tmp/profile.gz
5-
build --experimental_worker_max_multiplex_instances=KotlinCompile=5
5+
build --worker_max_multiplex_instances=KotlinCompile=5

0 commit comments

Comments
 (0)