Skip to content

Commit 938d2a4

Browse files
committed
chore:fixed tests
1 parent dc70597 commit 938d2a4

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

bc_obps/reporting/tests/api/test_report_version_endpoint.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ def test_unauthorized_users_cannot_post_report_version(self):
3939
assert response.status_code == 401
4040

4141
def test_authorized_users_can_post_updates_to_report_version(self):
42-
report_version = report_version_baker()
42+
report_version = report_version_baker(report_type="Initial Report")
43+
4344
TestUtils.authorize_current_user_as_operator_user(self, operator=report_version.report.operator)
4445

4546
endpoint_under_test = f'/api/reporting/report-version/{report_version.id}/report-operation'
@@ -54,32 +55,25 @@ def test_authorized_users_can_post_updates_to_report_version(self):
5455
"activities": [],
5556
"regulated_products": [],
5657
"operation_representative_name": "new operation representative name",
57-
"operation_report_type": "LFO", # This belongs to ReportVersion, not ReportOperation
58+
"operation_report_type": "Annual Report",
5859
}
59-
60-
# Assert changes for ReportOperation fields
6160
assert report_version.report_operation.operator_legal_name != data['operator_legal_name']
6261
assert report_version.report_operation.operator_trade_name != data['operator_trade_name']
6362
assert report_version.report_operation.operation_name != data['operation_name']
6463
assert report_version.report_operation.operation_bcghgid != data['operation_bcghgid']
6564
assert report_version.report_operation.bc_obps_regulated_operation_id != data['bc_obps_regulated_operation_id']
6665
assert report_version.report_operation.operation_representative_name != data['operation_representative_name']
67-
68-
# Assert change for ReportVersion field
69-
assert report_version.report_type != data['operation_report_type'] # Correctly assert for ReportVersion
66+
assert report_version.report_type != data['operation_report_type']
7067

7168
response = TestUtils.mock_post_with_auth_role(
7269
self, 'industry_user', self.content_type, data, endpoint_under_test
7370
)
7471

7572
assert response.status_code == 201
7673
response_json = response.json()
77-
78-
# Assert response for ReportOperation fields
7974
assert response_json['operator_legal_name'] == data['operator_legal_name']
8075
assert response_json['operator_trade_name'] == data['operator_trade_name']
8176
assert response_json['operation_name'] == data['operation_name']
8277
assert response_json['operation_bcghgid'] == data['operation_bcghgid']
8378
assert response_json['bc_obps_regulated_operation_id'] == data['bc_obps_regulated_operation_id']
8479
assert response_json['operation_representative_name'] == data['operation_representative_name']
85-

bc_obps/reporting/tests/models/test_report_version.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ def setUpTestData(cls):
1111
*TIMESTAMP_COMMON_FIELDS,
1212
("id", "ID", None, None),
1313
("report", "report", None, None),
14+
("report_type", "report type", None, None),
1415
("is_latest_submitted", "is latest submitted", None, None),
1516
("status", "status", 1000, None),
1617
("facility_reports", "facility report", None, 0),

0 commit comments

Comments
 (0)