Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/custom certs #130

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

Feature/custom certs #130

wants to merge 16 commits into from

Conversation

rustyjux
Copy link
Contributor

@rustyjux rustyjux commented Nov 18, 2024

Description

Fixes:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@rustyjux
Copy link
Contributor Author

Currently deployed in dev (Silver, Gold/DR) at 5ba7708

Can see example route in Gold - https://console.apps.gold.devops.gov.bc.ca/k8s/ns/b8840c-dev/routes/wild-ns-gw-41c0c-webapps.gov.bc.ca from:

# contains .api.gov.bc.ca certificate which is also valid for webapps.gov.bc.ca
certificates:
  - cert: "NORMAL_DATA_API_CERT"
    key: "NORMAL_DATA_API_KEY"
    tags: [ns.gw-41c0c]
    id: 73600400-dc9b-45be-9518-47cb0e6b203e
    snis:
      - name: webapps.gov.bc.ca
        id: 79009c9e-0f4d-40b5-9707-bf2fe9f50502
        tags: [ns.gw-41c0c]
services:
  - name: that-custom-one
    host: httpbin.org
    tags: [ns.gw-41c0c]
    port: 443
    protocol: https
    routes:
      - name: test-aps-webapps
        tags: [ns.gw-41c0c, random]
        hosts:
          - webapps.gov.bc.ca
  - name: another-non-custom-one
    host: httpbin.org
    tags: [ns.gw-41c0c]
    port: 443
    protocol: https
    routes:
      - name: that-non-custom-one
        tags: [ns.gw-41c0c]
        hosts:
          - new.api.gov.bc.ca

@rustyjux rustyjux marked this pull request as ready for review November 18, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant