Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-2994 - Regression: phone number extensions should all be numeric-only #1666

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

glen-aot
Copy link
Collaborator

@glen-aot glen-aot commented Nov 15, 2024

Description

change CustomFormComponent inside ContactDetails for phone2Extension to type='number'

Fixes #ORV2-2994

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

sonarcloud bot commented Nov 15, 2024

Copy link

sonarcloud bot commented Nov 15, 2024

Copy link

sonarcloud bot commented Nov 15, 2024

Copy link

sonarcloud bot commented Nov 15, 2024

Copy link

sonarcloud bot commented Nov 15, 2024

@glen-aot glen-aot merged commit bc5fd5c into main Nov 18, 2024
23 checks passed
@glen-aot glen-aot deleted the ORV2-2994 branch November 18, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants