forked from RobertCNelson/bb.org-overlays
-
Notifications
You must be signed in to change notification settings - Fork 178
Open
Description
Summary
The header comment in src/arm/MCP2515-SPI0.dts suggests adding the following to /boot/uEnv.txt:
uboot_overlay_addr0=/lib/firmware/BB-SPIDEV0-00A0.dtbo
uboot_overlay_addr1=/lib/firmware/MCP2515.dtbo
However, the .dts file in this repo is named MCP2515-SPI0.dts, so the Makefile will build MCP2515-SPI0.dtbo (not MCP2515.dtbo). That name mismatch is likely to confuse users and scripts that follow the example in the header.
Why this is an issue
- Users following the header example may look for or install
MCP2515.dtbowhich won't exist when building from this repo. - It's a documentation mismatch that is trivial to fix and does not require hardware to validate.
Repro steps
- Inspect the file header:
src/arm/MCP2515-SPI0.dts - Observe the example overlay names (lines near the top of the file). Example:
uboot_overlay_addr1=/lib/firmware/MCP2515.dtbo. - Confirm repo filename:
ls src/arm | grep MCP2515➜MCP2515-SPI0.dts(so built dtbo will beMCP2515-SPI0.dtbo). - Confirm Makefile rule:
$(patsubst %.dts,%.dtbo,$(ALL_DTS))(builds .dtbo from .dts basenames).
Suggested fix
- Update the header example to reference the correct built filename, e.g.:
uboot_overlay_addr0=/lib/firmware/BB-SPIDEV0-00A0.dtbo
uboot_overlay_addr1=/lib/firmware/MCP2515-SPI0.dtbo
- Or, if the upstream example expects the file to be named
MCP2515.dtbo, add a short note explaining the naming difference and why the repo buildsMCP2515-SPI0.dtbo.
Notes
- This is a code/docs-only issue and does not require hardware verification. I can prepare a small patch to update the header if maintainers agree with the suggested change.
Suggested labels: overlay, documentation, good-first-issue
Metadata
Metadata
Assignees
Labels
No labels