Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid codeowners should be filtered out #9

Open
pratikmallya opened this issue Apr 22, 2020 · 2 comments
Open

Invalid codeowners should be filtered out #9

pratikmallya opened this issue Apr 22, 2020 · 2 comments

Comments

@pratikmallya
Copy link

e.g. if a file has a codeowners like:

a/** cool-team # TODO: change

this library spits out 4 code owners: cool-team, #, TODO: and change. While nothing can be done for change at least # is a known invalid codeowner

@ThisIsMissEm
Copy link

afaik, You can't have comments on rule lines, so this would actually be invalid. You'd have to write:

# TODO: change
a/** @cool-team

Further more, you'd need the @ sign for GitHub and GitLab to handle the team/username correctly.

See:

@pratikmallya
Copy link
Author

For invalid syntax, perhaps the library should indicate that and/or fail rather than continuing to parse the invalid data and generating invalid codeowners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants