Skip to content

Commit 555226b

Browse files
authored
Merge pull request #12 from beeware/canvas-dpi-fix
Update canvas usage to remove use of DPI
2 parents 72451e4 + ba31aa6 commit 555226b

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

changes/12.bugfix.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Removed use of DPI-based canvas APIs.

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ include_package_data = True
4040
package_dir=
4141
= src
4242
install_requires =
43-
toga >= 0.3.0.dev19
43+
toga >= 0.3.0.dev22
4444
matplotlib >= 3.0.3
4545

4646
[options.packages.find]

src/toga_chart/chart.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def draw(self, figure):
3434
self.figure = figure
3535
FigureCanvasBase.__init__(self, self.figure)
3636
l, b, w, h = self.figure.bbox.bounds
37-
renderer = ChartRenderer(self, w, h, self._impl.container.viewport.dpi)
37+
renderer = ChartRenderer(self, w, h)
3838
self.figure.draw(renderer)
3939

4040

@@ -46,10 +46,8 @@ class ChartRenderer(RendererBase):
4646
renderer (:obj:`Canvas`): canvas to render onto
4747
width (int): width of canvas
4848
height (int): height of canvas
49-
dpi (int): dots per inch of the canvas
5049
"""
51-
def __init__(self, renderer, width, height, dpi):
52-
self.dpi = dpi
50+
def __init__(self, renderer, width, height):
5351
self.width = width
5452
self.height = height
5553
self._renderer = renderer
@@ -134,10 +132,8 @@ def get_text_width_height_descent(self, s, prop, ismath):
134132
get the width and height in display coords of the string s
135133
with FontPropertry prop
136134
"""
137-
138135
font = self.get_font(prop)
139-
140-
w, h = font.measure(s, dpi=self.dpi)
136+
w, h = self._renderer.measure_text(s, font)
141137
return w, h, 1
142138

143139
def get_font(self, prop):
@@ -157,6 +153,3 @@ def get_font(self, prop):
157153

158154
def to_toga_color(self, r, g, b, a):
159155
return parse_color(rgba(r * 255, g * 255, b * 255, a))
160-
161-
def points_to_pixels(self, points):
162-
return points * self.dpi / 72

0 commit comments

Comments
 (0)