Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to do less in-memory caching of compendiums #699

Closed
ben opened this issue Mar 25, 2023 · 2 comments
Closed

Try to do less in-memory caching of compendiums #699

ben opened this issue Mar 25, 2023 · 2 comments

Comments

@ben
Copy link
Owner

ben commented Mar 25, 2023

Had a chat on the League discord not long ago, and it got me thinking. We're doing a lot of work to keep the compendiums fresh. I wonder if it might instead be better to do something like pack.getIndex({fields: ['system.dfid']}) to get index information, and then do async loads when we need actual documents.

@rsek
Copy link
Collaborator

rsek commented May 14, 2023

already told ben about this a while back, but for posterity: i've experimented with this on local branches, and it does work. it can even point at flags, so we could index e.g. RollTables with flags.foundry-ironsworn.dfid

@ben
Copy link
Owner Author

ben commented Aug 30, 2024

Managed to finish this with #1023; we're no longer doing any pack.getDocuments() calls, except when showing a setting-truths dialog, which is okay because at that point we need them all.

@ben ben closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants