Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize assignment wrapper #326

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Optimize assignment wrapper #326

wants to merge 4 commits into from

Conversation

zodern
Copy link
Contributor

@zodern zodern commented Nov 19, 2021 •
edited
Loading

Fixes #277.

  • before wrapping an assignment to a variable with the same name as an export, it now checks that it is the exported variable instead of a variable from a different scope with the same name
  • the wrapper can now pass a list of exports that the assignment potentially modified, so reify can skip running getters/setters for the other exports.

@filipenevola filipenevola mentioned this pull request Nov 24, 2021
Merged
@zodern zodern mentioned this pull request Nov 27, 2021
Merged
3 tasks
@zodern zodern changed the title Check scope before wrapping assignment Optimize assignment wrapper Nov 27, 2021
@benjamn benjamn self-requested a review November 29, 2021 01:19
filipenevola added a commit to meteor/reify that referenced this pull request Dec 21, 2021
@filipenevola
Merge pull request #1 from meteor/fix/check-scope-when-wrapping
a472eb1 
Check scope before wrapping assignment benjamn#326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamn benjamn Awaiting requested review from benjamn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected module.runSetters wrapping
1 participant
@zodern