Improve NotEnoughDataError

Author: bennycode

src/EMA/EMA.ts

@@ -47,7 +47,7 @@ export class EMA extends MovingAverage {
 
   override getResultOrThrow(): Big {
     if (this.pricesCounter < this.interval) {
-      throw new NotEnoughDataError();
+      throw new NotEnoughDataError(this.getRequiredInputs());
     }
 
     return this.result!;
@@ -94,7 +94,7 @@ export class FasterEMA extends FasterMovingAverage {
 
   override getResultOrThrow(): number {
     if (this.pricesCounter < this.interval) {
-      throw new NotEnoughDataError();
+      throw new NotEnoughDataError(this.getRequiredInputs());
     }
 
     return this.result!;

src/Indicator.ts

@@ -29,7 +29,7 @@ export abstract class TechnicalIndicator<Result, Input> implements Indicator<Res
 
   getResultOrThrow() {
     if (this.result === undefined) {
-      throw new NotEnoughDataError();
+      throw new NotEnoughDataError(this.getRequiredInputs());
     }
 
     return this.result;

src/LINREG/LinearRegression.ts

@@ -75,7 +75,7 @@ export class LinearRegression extends TechnicalIndicator<LinearRegressionResult,
 
   override getResultOrThrow(): LinearRegressionResult {
     if (this.prices.length < this.interval) {
-      throw new NotEnoughDataError();
+      throw new NotEnoughDataError(this.getRequiredInputs());
     }
     return this.result!;
   }
@@ -149,13 +149,6 @@ export class FasterLinearRegression extends TechnicalIndicator<FasterLinearRegre
     return (this.result = this.calculateRegression(this.prices));
   }
 
-  override getResultOrThrow(): FasterLinearRegressionResult {
-    if (!this.result) {
-      throw new NotEnoughDataError();
-    }
-    return this.result;
-  }
-
   override get isStable(): boolean {
     try {
       this.getResultOrThrow();

src/PSAR/PSAR.test.ts

@@ -416,12 +416,10 @@ describe('FasterPSAR (Number version)', () => {
     // Test the specific error message
     try {
       psar.getResultOrThrow();
+      expect.fail('Expected error to be an instance of Error');
     } catch (error) {
-      if (error instanceof Error) {
-        expect(error.message).toBe('PSAR requires at least 2 candles');
-      } else {
-        expect.fail('Expected error to be an instance of Error');
-      }
+      assert(error instanceof Error);
+      expect(error.message).toBe('Not enough data. A minimum of "2" inputs is required to perform the computation.');
     }
   });
 

src/PSAR/PSAR.ts

@@ -201,7 +201,7 @@ export class PSAR extends BigIndicatorSeries<HighLow> {
 
   override getResultOrThrow(): Big {
     if (this.lastSar === null) {
-      throw new NotEnoughDataError('PSAR requires at least 2 candles');
+      throw new NotEnoughDataError(this.getRequiredInputs());
     }
 
     return super.getResultOrThrow();
@@ -378,7 +378,7 @@ export class FasterPSAR extends NumberIndicatorSeries<HighLow<number>> {
 
   override getResultOrThrow(): number {
     if (this.lastSar === null) {
-      throw new NotEnoughDataError('PSAR requires at least 2 candles');
+      throw new NotEnoughDataError(this.getRequiredInputs());
     }
 
     return super.getResultOrThrow();

src/RMA/RMA.ts

@@ -47,7 +47,7 @@ export class RMA extends MovingAverage {
 
   override getResultOrThrow(): Big {
     if (this.pricesCounter < this.interval) {
-      throw new NotEnoughDataError();
+      throw new NotEnoughDataError(this.getRequiredInputs());
     }
 
     return this.result!;
@@ -94,7 +94,7 @@ export class FasterRMA extends FasterMovingAverage {
 
   override getResultOrThrow(): number {
     if (this.pricesCounter < this.interval) {
-      throw new NotEnoughDataError();
+      throw new NotEnoughDataError(this.getRequiredInputs());
     }
 
     return this.result!;

src/error/NotEnoughDataError.ts

@@ -1,6 +1,6 @@
 export class NotEnoughDataError extends Error {
-  constructor(message: string = 'Not enough data') {
-    super(message);
+  constructor(requiredAmount: number) {
+    super(`Not enough data. A minimum of "${requiredAmount}" inputs is required to perform the computation.`);
     Object.setPrototypeOf(this, new.target.prototype);
     this.name = 'NotEnoughDataError';
   }