Skip to content

Commit ef36b8f

Browse files
committed
f
1 parent ec2424a commit ef36b8f

File tree

6 files changed

+27
-6
lines changed

6 files changed

+27
-6
lines changed

β€Žcontainer_images/buildah/Dockerfileβ€Ž

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,19 @@ RUN touch /etc/subgid /etc/subuid \
77

88
ENV BUILDAH_ISOLATION=chroot
99

10+
ARG BENTO_USER=bentoml
11+
ARG BENTO_USER_UID=1034
12+
ARG BENTO_USER_GID=1034
13+
RUN groupadd -g $BENTO_USER_GID -o $BENTO_USER && useradd -m -u $BENTO_USER_UID -g $BENTO_USER_GID -o -r $BENTO_USER
14+
15+
RUN echo $BENTO_USER:$BENTO_USER_UID:$BENTO_USER_GID >> /etc/subuid \
16+
&& echo $BENTO_USER:$BENTO_USER_UID:$BENTO_USER_GID >> /etc/subgid
17+
18+
RUN echo "export BUILDAH_ISOLATION=chroot" >> /home/build/.bashrc
19+
20+
RUN mkdir -p /home/build/.config/containers \
21+
&& (echo '[storage]';echo 'driver = "vfs"') > /home/build/.config/containers/storage.conf
22+
1023
USER build
1124
WORKDIR /home/build
1225

β€Žcontainer_images/buildah/Makefileβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
IMAGE := quay.io/bentoml/bentoml-buildah:0.0.1
1+
IMAGE := quay.io/bentoml/bentoml-buildah:0.0.3
22

33
build:
44
docker build -t ${IMAGE} .

β€Žcontrollers/resources/bentorequest_controller.goβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1604,6 +1604,10 @@ echo "Done"
16041604
inClusterImageName,
16051605
),
16061606
}
1607+
envs = append(envs, corev1.EnvVar{
1608+
Name: "BUILDAH_ISOLATION",
1609+
Value: "chroot",
1610+
})
16071611
default:
16081612
err = errors.Errorf("unknown bento image build engine %s", buildEngine)
16091613
return

β€Žhelm/yatai-image-builder/values.yamlβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ internalImages:
100100
kaniko: quay.io/bentoml/kaniko:1.9.1
101101
buildkit: quay.io/bentoml/buildkit:master
102102
buildkitRootless: quay.io/bentoml/buildkit:master-rootless
103-
buildah: quay.io/bentoml/bentoml-buildah:0.0.1
103+
buildah: quay.io/bentoml/bentoml-buildah:0.0.2
104104

105105
bentoImageBuildEngine: kaniko # options: kaniko, buildkit, buildkit-rootless
106106
runInOpenshift: false

β€Žscripts/start-dev.shβ€Ž

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,5 +58,9 @@ function trap_handler() {
5858
trap trap_handler EXIT
5959

6060
echo "βŒ› starting yatai-image-builder..."
61-
env $(kubectl -n yatai-image-builder get secret yatai-image-builder-env -o jsonpath='{.data}' | $jq 'to_entries|map("\(.key)=\(.value|@base64d)")|.[]' | xargs) make run
61+
env $(kubectl -n yatai-image-builder get secret yatai-image-builder-env -o jsonpath='{.data}' | $jq 'to_entries|map("\(.key)=\(.value|@base64d)")|.[]' | xargs) \
62+
BENTO_IMAGE_BUILD_ENGINE=buildah \
63+
INTERNAL_IMAGES_BENTO_DOWNLOADER=quay.io/bentoml/bento-downloader:0.0.3 \
64+
INTERNAL_IMAGES_BUILDAH=quay.io/bentoml/bentoml-buildah:0.0.2 \
65+
make run
6266

β€Žtests/e2e/installation_test.shβ€Ž

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
set -xe
44

5-
kubectl create ns yatai-system
6-
kubectl create ns yatai-image-builder
5+
kubectl create ns yatai-system || true
6+
kubectl create ns yatai-image-builder || true
77
kubectl create ns yatai || true
88

99
echo "πŸš€ Creating AWS Secret Access Key..."
10-
kubectl create secret generic aws-secret-access-key --from-literal=AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY} --namespace yatai-image-builder
10+
kubectl create secret generic aws-secret-access-key --from-literal=AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY} --namespace yatai-image-builder || true
1111
echo "πŸš€ Installing yatai-image-builder..."
1212
YATAI_ENDPOINT='empty' USE_LOCAL_HELM_CHART=true UPGRADE_CRDS=false AWS_SECRET_ACCESS_KEY_EXISTING_SECRET_NAME=aws-secret-access-key AWS_SECRET_ACCESS_KEY_EXISTING_SECRET_KEY=AWS_SECRET_ACCESS_KEY bash ./scripts/quick-install-yatai-image-builder.sh
1313
echo "yatai-image-builder helm release values:"

0 commit comments

Comments
Β (0)