-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some updates #1
Comments
One more which I omitted upon seeing the latest commit message: although svundef2* are implemented, svundef_u8 etc. for single vectors are not, though they are provided by llvm's arm_sve.h (example). |
@jan-wassenberg I am not use to github but finally I think it would be more efficient if you could push the code directly (with a PR?), and feel free to add you to the readme as author if you want. |
@berenger-eu thanks for your trust. I'm also (still) not a Git expert but should manage. Would it be OK if I sent an PR which is the result of running clang-format, then the patch? |
Output of clang-format -style=Google -i farm_sve.h; refs #1
Hi, thanks for farm_sve! I've hooked it up to Highway's tests and noticed some issues:
These are implemented in patch.txt, which is applied to the clang-format output of
wget https://gitlab.inria.fr/bramas/farm-sve/-/raw/master/farm_sve.h?inline=false
.Note that svunpkhi_b is a hack: we need it to expand a 16-bit mask to 32-bit, and this is hardcoded in the implementation. To exactly match SVE, I think we'd need to have one predicate bit per byte in the type, then we could have a type-agnostic unpklo/hi_b.
Please let me know if you disagree with any of the other changes.
The text was updated successfully, but these errors were encountered: