Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Click on Starter Pokemon ball to see info #308

Open
UTDZac opened this issue Dec 2, 2022 · 5 comments
Open

Feature Request: Click on Starter Pokemon ball to see info #308

UTDZac opened this issue Dec 2, 2022 · 5 comments
Labels
Feature Request A new feature idea

Comments

@UTDZac
Copy link
Collaborator

UTDZac commented Dec 2, 2022

Prior to selecting a Pokemon starter from any of the three ball choices, the player should have the ability to display the current Pokemon being viewed but before the player actually selects it as their chosen Pokemon. There might exist a Battle Comm message of sorts similar to how the "Learning a new move" message is triggered to allow user to click on it for more info.

The Tracker screen can change to the Pokemon Info Lookup screen. This shows the Pokemon's BST and types, useful for randomized types, weaknesses, etc

EDIT: I wrote "Click on starter ball" but the act of clicking probably isn't necessarily.

image

@UTDZac UTDZac added the Feature Request A new feature idea label Dec 2, 2022
@UTDZac
Copy link
Collaborator Author

UTDZac commented Dec 2, 2022

Note that this may behave differently between any of the five games (FRLG / RSE), and/or languages available.

@TeamZ3N
Copy link

TeamZ3N commented Feb 1, 2023

Something like this for those of us who don't have BST, moves, weaknesses memorized.
Mashup

@Fellshadow
Copy link
Collaborator

Started working on this, got a basic version working for FRLG so far:

StarterInfoDemo

It's not so bad in FRLG, the starter species shown is stored via a temporary variable in the vars array in SaveBlock1 which we already have access to (the repel step counter is also in that array). We have this already for the non-english FRLG too. Decomp reference here

The annoying part, is that this species is not cleared when you decline a starter, making it tricky to logically determine when to swap between the tracker screen (to show the random ball choice) and the info screen for the displayed pokemon

What i've gone with so far is reading VAR_RESULT which is used for the player's selection on taking the starter (conveniently set to 255 while the dialogue box is open) to decide when to display the info as shown in the gif

As for RSE, well unfortunately they use the gTasks list for handling the starter choice menu so it's much trickier there.

My current idea is to investigate if it's possible to read what the three starters are, determine that the bag is open, and then read the player inputs to cycle between info pages for the starters as the game cycles through the starters. Failing that could always try to implement it as a click-based feature at least

@TeamZ3N
Copy link

TeamZ3N commented Feb 4, 2023

@Fellshadow This looks fantastic for FRLG!

UTDZac added a commit that referenced this issue Nov 14, 2024
resolves #308

When selecting a starter Pokémon ball, the tracker will now automatically display the InfoScreen for that Pokémon. This is a new option (enabled by default) the user adjust, under the Gameplay settings screen.
@UTDZac
Copy link
Collaborator Author

UTDZac commented Nov 14, 2024

Just completed this feature. It works for Ruby, Sapphire, Emerald, FireRed, and LeafGreen.

It will be available in the next Tracker release after version 8.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request A new feature idea
Projects
None yet
Development

No branches or pull requests

3 participants