Skip to content

Empty email addresses must not be canonicalized #2

Open
@dpoon

Description

@dpoon

Email addresses are optional. Very bad things happen if we treat all users who have no email address as the same user.

Example:

  1. $RT::Config::ValidateUserEmailAddresses is enabled (as per default)
  2. There exists user "A" whose EmailAddress is empty.
  3. There exists user "B" whose EmailAddress is '[email protected]'.
  4. User A is merged into User B.

Suppose RT::Interface::Web::AttemptExternalAuth() calls

$UserObj->Create(Name => ..., Gecos => ...);

The call will fail, since the call gets canonicalized to

$UserObj->Create(
    Name => ..., Gecos => ...,
    EmailAddress => '[email protected]'
);

and RT::User::ValidateUserEmailAddress() will reject it with an "Email address in use" error.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions