refactor(Cantines): Nouvelle queryset pour récupérer les satellites à partir d'un siret

Author: raphodn

api/views/canteen.py

@@ -1020,10 +1020,7 @@ def annotate_actions(queryset, year):
         # prep add satellites action
         # https://docs.djangoproject.com/en/4.1/ref/models/expressions/#using-aggregates-within-a-subquery-expression
         satellites = (
-            Canteen.objects.filter(
-                central_producer_siret=OuterRef("siret"),
-                production_type=Canteen.ProductionType.ON_SITE_CENTRAL,
-            )
+            Canteen.objects.get_satellites(OuterRef("siret"))
             .order_by()
             .values("central_producer_siret")  # sets the groupBy for the aggregation
         )

data/models/canteen.py

@@ -95,6 +95,9 @@ def publicly_hidden(self):
             else self.exclude(publication_status=Canteen.PublicationStatus.PUBLISHED)
         )
 
+    def get_satellites(self, central_producer_siret):
+        return self.filter(is_satellite_query(), central_producer_siret=central_producer_siret)
+
     def annotate_with_requires_line_ministry(self):
         canteen_sector_relation = apps.get_model(app_label="data", model_name="Canteen_sectors")
         has_sector_requiring_line_ministry = canteen_sector_relation.objects.filter(
@@ -169,6 +172,38 @@ class Actions(models.TextChoices):
         PUBLISH = "50_publish", "Publier"
         NOTHING = "95_nothing", "Rien à faire !"
 
+    class Sectors(models.TextChoices):
+        """
+        Restaurants des prisons administration True
+        Restaurants administratifs d’Etat (RA) administration True
+        Restaurants des armées / police / gendarmerie administration True
+        Etablissements publics d’Etat (EPA ou EPIC) administration True
+        Supérieur et Universitaire education True
+        Autres structures d’enseignement education True
+        Etablissements de la PJJ social True
+        Hôpitaux health False
+        Autres établissements de soins health False
+        Restaurants inter-administratifs d’État (RIA) administration True
+        Etablissements d’enseignement agricole education False
+        Autres établissements sociaux et médico-sociaux social False
+        Autres établissements de loisirs leisure False
+        Restaurants d’entreprises enterprise False
+        Restaurants inter-entreprises enterprise False
+        Restaurants administratifs des collectivités territoriales administration False
+        Secondaire collège education False
+        Ecole primaire (maternelle et élémentaire) education False
+        Cliniques health False
+        Secondaire lycée (hors agricole) education False
+        Crèche social False
+        Autres établissements non listés autres False
+        EHPAD / maisons de retraite / foyers de personnes âgées social False
+        IME / ITEP social False
+        ESAT / Etablissements spécialisés social False
+        Centre de vacances / sportif leisure False
+        """
+
+        ADMINISTRATION_PRISONS = "administration", "Restaurants des prisons"
+
     class Ministries(models.TextChoices):
         AFFAIRES_ETRANGERES = "affaires_etrangeres", "Affaires étrangères"
         AGRICULTURE = "agriculture", "Agriculture, Alimentation et Forêts"
@@ -380,10 +415,7 @@ def is_serving(self):
     @property
     def satellites(self):
         if self.siret:
-            return Canteen.objects.filter(
-                central_producer_siret=self.siret,
-                production_type=Canteen.ProductionType.ON_SITE_CENTRAL,
-            )
+            return Canteen.objects.get_satellites(self.siret)
         return Canteen.objects.none()
 
     @property

data/signals.py

@@ -32,10 +32,7 @@ def update_satellites_siret(sender, instance, raw, using, update_fields, **kwarg
             logger.info(
                 f"SIRET change. Central kitchen {instance.id} ({instance.name}) changed its SIRET from {obj.siret} to {instance.siret}"
             )
-            satellites = Canteen.objects.filter(
-                central_producer_siret=obj.siret,
-                production_type=Canteen.ProductionType.ON_SITE_CENTRAL,
-            ).only("id")
+            satellites = Canteen.objects.get_satellites(obj.siret).only("id")
             for satellite in satellites:
                 logger.info(
                     f"SIRET change. Satellite cantine {satellite.id} had its central_producer_siret changed automatically from {obj.siret} to {instance.siret}"