Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freezing up on large responses (w/ workaround) #75

Open
joshhendo opened this issue Feb 25, 2019 · 0 comments
Open

Freezing up on large responses (w/ workaround) #75

joshhendo opened this issue Feb 25, 2019 · 0 comments

Comments

@joshhendo
Copy link

joshhendo commented Feb 25, 2019

There's an issue with the last few versions of Chrome that cause accessing the innerText of an element to take significantly longer than before (~70x in my testing). This causes problems performing highlighting on large datasets due to to this line:
https://github.com/bevacqua/horsey/blob/master/horsey.js#L392

In my case, processing a 3000 character response causes Chrome to freeze for approx. 6000ms.

This looks like it will be fixed in a future version of Chrome, so likely doesn't need a long term patch in horsey. However, if anyone is facing this issue and needs an immediate fix, a workaround is to remove innerText from the line above and rely solely on textContent.

The associated bug in Chromium is: https://bugs.chromium.org/p/chromium/issues/detail?id=935237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant