Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Make "You are now playing" sound play while watching replays. #702

Open
sprEEEzy opened this issue Jun 7, 2024 · 1 comment
Open

Comments

@sprEEEzy
Copy link

sprEEEzy commented Jun 7, 2024

If you're watching a replay, the "You are now playing" sound when you go thru the lobby queue only seems to play when you open the lobby screen. It doesn't play while watching the replay.

This would greatly decrease the amount of people players have to force spectate, because they don't notice that they made it in.

@FIr3baL
Copy link
Collaborator

FIr3baL commented Aug 10, 2024

This was added last year Sep
#463
d61e087

Did you face it in one of the 2 exceptions, i mentioned above ?

If not, can you please describe in detail how to reproduce ?
I just tested locally and it works as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants