Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CLIENTBATTLESTATUS is sent for users not in a battle #403

Open
FIr3baL opened this issue Aug 6, 2024 · 0 comments
Open

[Bug]: CLIENTBATTLESTATUS is sent for users not in a battle #403

FIr3baL opened this issue Aug 6, 2024 · 0 comments
Labels
bug Something isn't working low priority

Comments

@FIr3baL
Copy link
Contributor

FIr3baL commented Aug 6, 2024

Describe the Bug

If you change your client status, teiserver reacts with an unexpected CLIENTBATTLESTATUS.
The value equals the last known battle status, when the user was in a lobby.

One would need to find out, why this was initially added.
Maybe it's covering any edge cases.
Otherwise it's just a wrong implementation of spring protocol and can lead clients to wrong assumptions. (Like it's happening for chobby)

<-- Fireball: MYSTATUS 0
--> Fireball: CLIENTSTATUS Fireball 0
--> Fireball: CLIENTBATTLESTATUS Fireball 4194304 14717473

Reproduce the bug

  1. you are in a lobby and go away (=5min.)
  2. the spads instances are pkill'ed like with the engine update playbook (and BATTLECLOSED is sent, chobby cleans up everything)
    (spads restarts its instances...) pkill -f 'spads.pl.*InstanceName='
  3. you move mouse and send MYSTATUS 0 indicatiing you are back
  4. Now teiserver does not only confirm the MYSTATUS by CLIENTSTATUS 0, but additionally with CLIENTBATTLESTATUS

Alternativly just start chobby in debug mode and

  1. Go to chat -> Debug
  2. Type MYSTATUS 0

Screenshots

No response

Additional context

No response

@FIr3baL FIr3baL added the bug Something isn't working label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority
Projects
None yet
Development

No branches or pull requests

2 participants