Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Allow anyone with the password to join lobby even with gatekeeper on #470

Open
AntlerForce opened this issue Sep 14, 2024 · 1 comment
Labels
feature request Not broken but something we want added medium priority

Comments

@AntlerForce
Copy link

Describe the Feature

Currently if gatekeeper is enabled for a room all joins from non-friends are blocked even if they have the correct password. There is no message about the block and from the would-be-joiners perspective it just appears that "nothing happens".

IMO having the gatekeeper allow friends passwordless access and still accept the distributed password from non-friends would be much more useful and less confusing.

Expected Behavior

Enabling gatekeeper allows friends joining without inputting the password, while not preventing those who are not friends but have the password from joining.

Screenshots

No response

Additional context

This is a chobby PR that I am not comfortable merging while gatekeeper operates in the current way, as it is confusing why a password is given which doesn't actually allow people to join: beyond-all-reason/BYAR-Chobby#665

@AntlerForce AntlerForce added the feature request Not broken but something we want added label Sep 14, 2024
@jauggy
Copy link
Member

jauggy commented Sep 16, 2024

It seems like the original intention for gatekeeper friends is for non-passworded lobbies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Not broken but something we want added medium priority
Projects
None yet
Development

No branches or pull requests

3 participants