Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side effect in check_arxiv_published #5

Open
johngarg opened this issue Mar 23, 2021 · 0 comments
Open

Side effect in check_arxiv_published #5

johngarg opened this issue Mar 23, 2021 · 0 comments

Comments

@johngarg
Copy link

Hi,

Currently the check_arxiv_published function prints a message if the arXiv item cannot be found:

print("\t\nArxiv not found.")

I am using this function in another project and want to control the messages printed to the terminal. Since the first element of the returned tuple contains the "found" status of the item, could I suggest adding a verbose flag with a default True value? This shouldn't affect any existing use of the function, and would allow it to be called without the side effect.

I've already made the changes in my fork of the repo, and can submit the pull request if the maintainers are happy.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant