-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Inconsistent definition of AcquisitionDuration #1906
Comments
Even the DICOM definitions might not be ideal:
I wonder if there's something in the realm of "the time required to execute the program responsible for image data acquisition"; that would exclude sequence-agnostic features like patient prep / re-shimming, but rightly include things like establishing magnetisation steady-state. |
Short term fix is to add selectors to only apply the mutex for BOLD images: bids-specification/src/schema/rules/checks/func.yaml Lines 95 to 106 in 5fc3528
|
After a couple months, I'm still undermotivated to come up with a sentence that satisfies multiple modalities. We can use |
why would we want to capture that? IMHO such data does not fall under "Acquisition" since
1.b If we were looking to capture all those, could be some
"The time in seconds spent on acquisition of data" since "needed to complete" might imply all the preparation, and who knows - may be some "cool down" if there was any, etc.
I feel that this relates to ability to
In principle it could be implemented earlier, but I think then no amount of documentation would suffice since it might be too intrusive and "violate" the promise of compatibility within 1.x series. So what about slating it for 2.0.0 release?
|
My thinking was less so about what one might "want to capture" but rather what the contents of the pre-existing DICOM header field encodes, is therefore likely to appear in JSON data that have undergone conversion from DICOM somewhat agnostic to BIDS, and therefore what the BIDS description of that field should be to be faithful. Having a BIDS field where the name is identical to a DICOM field, but the intended contents are different, is probably asking for trouble (and indeed the raison d'etre of this Issue).
I think this might be a misunderstanding of the diagram: The time taken to reach steady-state magnetisation is the green highlight. That is specific to the particular pulse sequence being executed, and is included as part of the DICOM field AcquisitionDuration. What this looks like and how long it takes will depend on the sequence / parameters provided to that sequence. The parts that are not included in DICOM AcquisitionDuration is the red highlight, which is what I referred to previously as "patient prep / re-shimming"; this is everything that happens prior to the scanner saying eg. "execute the program called MPRAGE". |
The current definition of
AcquisitionDuration
isThe definition of DICOM tag 0018, 9073 is:
They also helpfully provide a graphic to clarify the definition:
So this is the duration of the full scan, which only overlaps for single-volume acquisitions. Our definition more closely aligns with
FrameAcqusitionDuration
0018,9220:I propose the following (re)definitions:
This change needs to be communicated somehow. While upstream tools are going to refer to DICOM, downstream tools may only refer to BIDS. Any suggestions for wording?
The text was updated successfully, but these errors were encountered: