Skip to content

[FIX] Render phenotype sidecar and genetic info tables from schema #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
effigies wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −16
Open

[FIX] Render phenotype sidecar and genetic info tables from schema #2324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ee9a50
fix(render): Move phenotype metadata table into schema
effigies Jan 23, 2026
a71e404
fix(render): Render genetic_info.json table from schema
effigies Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/modality-agnostic-files/phenotypic-and-assessment-data.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,7 @@ The definitions of these fields can be found in
and a guide for using macros can be found at
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md
-->
{{ MACROS___make_metadata_table(
{
"MeasurementToolMetadata": "OPTIONAL",
"Derivative": "OPTIONAL",
}
) }}
{{ MACROS___make_sidecar_table('phenotype.Phenotype') }}

As an example, consider the contents of a file called
`phenotype/acds_adult.json`:
Expand Down
11 changes: 1 addition & 10 deletions src/modality-specific-files/genetic-descriptor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,7 @@ The definitions of these fields can be found in
and a guide for using macros can be found at
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md
-->
{{ MACROS___make_metadata_table(
{
"GeneticLevel": "REQUIRED",
"AnalyticalApproach": "OPTIONAL",
"SampleOrigin": "REQUIRED",
"TissueOrigin": "OPTIONAL",
"BrainLocation": "OPTIONAL",
"CellType": "OPTIONAL",
}
) }}
{{ MACROS___make_json_table('dataset_metadata.genetic_info') }}

To ensure dataset description consistency, we recommend following [Multi-omics approaches to disease](https://genomebiology.biomedcentral.com/articles/10.1186/s13059-017-1215-1) by Hasin et al. 2017 to determine the `GeneticLevel:`

Expand Down
8 changes: 8 additions & 0 deletions src/schema/rules/sidecars/phenotype.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---

Phenotype:
selectors:
- datatype == 'phenotype'
fields:
MeasurementToolMetadata: optional
Derivative: optional