Skip to content

Commit 0f4a5d2

Browse files
committed
add separate test args
1 parent 5546e2f commit 0f4a5d2

File tree

8 files changed

+25
-7
lines changed

8 files changed

+25
-7
lines changed

.github/workflows/build-images.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ jobs:
5050
if tag_exists $BASE_BUSYBOX_IMAGE_NAME $BASE_TAG \
5151
&& tag_exists $BASE_DEBIAN_IMAGE_NAME $BASE_TAG \
5252
&& tag_exists $BUILD_ENV_IMAGE_NAME $BIOCONDA_IMAGE_TAG \
53+
&& tag_exists $BOT_IMAGE_NAME $BIOCONDA_IMAGE_TAG \
54+
&& tag_exists $ISSUE_RESPONDER_IMAGE_NAME $BIOCONDA_IMAGE_TAG \
5355
&& tag_exists $CREATE_ENV_IMAGE_NAME $BIOCONDA_IMAGE_TAG; then
5456
echo "DO_BUILD=false" >> $GITHUB_OUTPUT
5557
else
@@ -104,6 +106,8 @@ jobs:
104106
time bash build.sh base-glibc-debian-bash
105107
time bash build.sh build-env
106108
time bash build.sh create-env
109+
time bash build.sh bot
110+
time bash build.sh bioconda-recipes-issue-responder
107111
108112
- name: Upload artifacts
109113
uses: actions/upload-artifact@v4

images/base-glibc-busybox-bash/prepare.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,6 @@ rm "${iidfile}"
2121
BUILD_ARGS=()
2222
BUILD_ARGS+=("--build-arg=debian_version=${DEBIAN_VERSION}")
2323
BUILD_ARGS+=("--build-arg=busybox_image=${busybox_image}")
24+
25+
TEST_ARGS=()
26+
TEST_ARGS+=("--build-arg=base=${IMAGE_NAME}:${TAG}-${CURRENT_ARCH}")

images/base-glibc-debian-bash/prepare.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,6 @@ IMAGE_NAME="${BASE_DEBIAN_IMAGE_NAME}"
33
TAG="$BASE_TAG"
44
BUILD_ARGS=()
55
BUILD_ARGS+=("--build-arg=debian_version=$DEBIAN_VERSION")
6+
7+
TEST_ARGS=()
8+
TEST_ARGS+=("--build-arg=base=${IMAGE_NAME}:${TAG}-${CURRENT_ARCH}")

images/bioconda-recipes-issue-responder/prepare.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,6 @@ ONLY_AMD64=true
1010
BUILD_ARGS=()
1111
BUILD_ARGS+=("--build-arg=create_env=${CREATE_ENV_IMAGE_NAME}:${BIOCONDA_IMAGE_TAG}-${CURRENT_ARCH}")
1212
BUILD_ARGS+=("--build-arg=base=${BASE_BUSYBOX_IMAGE_NAME}:${BASE_TAG}-${CURRENT_ARCH}")
13+
14+
TEST_ARGS=()
15+
TEST_ARGS+=("--build-arg=base=${IMAGE_NAME}:${TAG}-${CURRENT_ARCH}")

images/bot/prepare.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,7 @@ ONLY_AMD64=true
99

1010
BUILD_ARGS=()
1111
BUILD_ARGS+=("--build-arg=create_env=${CREATE_ENV_IMAGE_NAME}:${BIOCONDA_IMAGE_TAG}-${CURRENT_ARCH}")
12-
BUILD_ARGS+=("--build-arg=base=localhost/${BASE_BUSYBOX_IMAGE_NAME}:${BASE_TAG}-${CURRENT_ARCH}")
12+
BUILD_ARGS+=("--build-arg=base=${BASE_BUSYBOX_IMAGE_NAME}:${BASE_TAG}-${CURRENT_ARCH}")
13+
14+
TEST_ARGS=()
15+
TEST_ARGS+=("--build-arg=base=${IMAGE_NAME}:${TAG}-${CURRENT_ARCH}")

images/build-env/prepare.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,6 @@ BUILD_ARGS=()
2323
# Where to find the copied-over bioconda-utils
2424
BUILD_ARGS+=("--build-arg=BIOCONDA_UTILS_FOLDER=bioconda-utils")
2525
BUILD_ARGS+=("--build-arg=bioconda_utils_version=$BIOCONDA_UTILS_VERSION")
26+
27+
TEST_ARGS=()
28+
TEST_ARGS+=("--build-arg=base=${IMAGE_NAME}:${TAG}-${CURRENT_ARCH}")

images/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ for arch in $ARCHS; do
9595

9696
# Run basic test in Dockerfile.test
9797
buildah bud \
98-
--build-arg=base="$" \
98+
${TEST_ARGS[@]} \
9999
--file=Dockerfile.test \
100100
--build-arg=base="${image_id}"
101101

images/create-env/prepare.sh

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,8 @@ CONDA_VERSION=$(
1515
export CONDA_VERSION=${CONDA_VERSION%$'\r'}
1616

1717
BUILD_ARGS+=("--build-arg=CONDA_VERSION=$CONDA_VERSION")
18+
BUILD_ARGS+=("--build-arg=BUSYBOX_IMAGE=${BASE_BUSYBOX_IMAGE_NAME}:${BASE_TAG}-${CURRENT_ARCH}")
1819

19-
# Arguments to buildah bud are architecture-dependent
20-
BUILD_ARGS+=("--build-arg=BUSYBOX_IMAGE=localhost/${BASE_BUSYBOX_IMAGE_NAME}:${BASE_TAG}-${CURRENT_ARCH}")
21-
22-
# TEST_BUILD_ARGS=()
23-
# TEST_BUILD_ARGS+=("--build-arg=BUSYBOX_IMAGE=$BUSYBOX_IMAGE")
20+
TEST_ARGS=()
21+
TEST_ARGS+=("--build-arg=base=${IMAGE_NAME}:${TAG}-${CURRENT_ARCH}")
22+
TEST_ARGS+=("--build-arg=BUSYBOX_IMAGE=${BASE_BUSYBOX_IMAGE_NAME}:${BASE_TAG}-${CURRENT_ARCH}")

0 commit comments

Comments
 (0)