Merge pull request #4405 from VesnaT/same_domain_fix

[FIX] DataProjectionWidget: Update combos on new data

Author: janezd

Orange/widgets/visualize/tests/test_owprojectionwidget.py

@@ -11,6 +11,7 @@
 from Orange.widgets.tests.base import (
     WidgetTest, WidgetOutputsTestMixin, ProjectionWidgetTestMixin
 )
+from Orange.widgets.utils.colorpalettes import ContinuousPalettes
 from Orange.widgets.visualize.utils.widget import (
     OWDataProjectionWidget, OWProjectionWidgetBase
 )
@@ -230,6 +231,23 @@ def test_unconditional_commit_on_new_signal(self):
             self.send_signal(self.widget.Inputs.data, self.data)
             commit.assert_called()
 
+    def test_model_update(self):
+        widget = self.widget
+
+        data = Table("iris")
+        domain = data.domain
+
+        self.send_signal(widget.Inputs.data, data)
+        self.assertIs(widget.controls.attr_color.model()[4], domain[0])
+
+        copy0 = domain[0].copy()
+        assert copy0.palette.name != "linear_kryw_0_100_c71"
+        copy0.palette = ContinuousPalettes["linear_kryw_0_100_c71"]
+        domain = Domain((copy0, ) + domain.attributes[1:], domain.class_var)
+        data0 = data.transform(domain)
+        self.send_signal(widget.Inputs.data, data0)
+        self.assertIs(widget.controls.attr_color.model()[4], copy0)
+
 
 if __name__ == "__main__":
     unittest.main()

Orange/widgets/visualize/utils/widget.py

@@ -430,13 +430,10 @@ def effective_data(self):
     def set_data(self, data):
         data_existed = self.data is not None
         effective_data = self.effective_data if data_existed else None
-        same_domain = (data_existed and data is not None and
-                       data.domain.checksum() == self.data.domain.checksum())
         self.closeContext()
         self.data = data
         self.check_data()
-        if not same_domain:
-            self.init_attr_values()
+        self.init_attr_values()
         self.openContext(self.data)
         self._invalidated = not (
             data_existed and self.data is not None and