Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error thrown in OBO file parsing #341

Open
AndyMenzies opened this issue Apr 28, 2020 · 2 comments
Open

Error thrown in OBO file parsing #341

AndyMenzies opened this issue Apr 28, 2020 · 2 comments

Comments

@AndyMenzies
Copy link

When parsing OBO ontology files the following block is causing issues

$self->throw( "OBO File Format Error on line "

The error message states that a term has no ID or name, and that the term will be ignored. However it does this via a $self->throw call which raises an exception and causes the parsing to be unavoidably interrupted. The throw call is followed by a next which would skip the term if it could get there.

Which behaviour is intended? Is the malformed term supposed to be skipped, or is the parser supposed to error out?

@cjfields
Copy link
Member

cjfields commented Aug 6, 2020

@AndyMenzies can you point to an example file throwing the error so this could be tested?

@AndyMenzies
Copy link
Author

@cjfields I think I was trying to parse Uberon at the time, its quite large and I don't have a concise file that triggers the problem.

http://purl.obolibrary.org/obo/uberon/ext.obo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants