Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what is the aim? #1

Open
lbdroid opened this issue Apr 13, 2021 · 5 comments
Open

what is the aim? #1

lbdroid opened this issue Apr 13, 2021 · 5 comments

Comments

@lbdroid
Copy link

lbdroid commented Apr 13, 2021

First of all, you have a nasty name conflict with the "real" oksse: https://github.com/heremaps/oksse

And second, you seem to be building an SSE library on top of okhttp, which already covers SSE, so why does this project exist? Wouldn't it be smarter to contribute to okhttp?

@AkshayChordiya
Copy link
Contributor

AkshayChordiya commented Apr 14, 2021

Yeah unfortunately there is a conflict which we came across later, though there were plans to change the name but we couldn't come on an agreement. But I don't see it as a problem plus the heremaps/okssee doesn't seem to be maintained anymore.

OkHttp doesn't cover SSE, which is why if you see heremaps/okssee repository they have also built their SSE library on top of OkHttp.
We thought about contributing to OkHttp but OkHttp isn't a Kotlin Multiplatform yet (it can be but it will require good amount of work) and we wanted to build something generic and re-usable which KMP (Kotlin Multiplatform) offers.

Thanks for reaching out with your concerns. Let me know if you have any further questions.

@lbdroid
Copy link
Author

lbdroid commented Apr 15, 2021

okhttp certainly does cover SSE and I've been using it quite successfully:
https://github.com/square/okhttp/tree/master/okhttp-sse

@AkshayChordiya
Copy link
Contributor

Umm I see, that's good to know. That said the okhttp-sse is still experimental and anyway ultimately it's user's choice if to use this library or okhttp-sse or any other 🙃

The value this library adds is:

  1. Kotlin Multiplatform support (the biggest difference)
  2. It's not experimental API

@lbdroid
Copy link
Author

lbdroid commented Apr 15, 2021

But wouldn't it be a more useful choice to contribute to upstream?

@AkshayChordiya
Copy link
Contributor

Absolutely if okhttp was Kotlin Multiplatform then we would have 😉 and AFAIK it's not currently in their roadmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants