:bug: [BUG]: Error not failing the script execution on missing required variable

[fmigneault]

Summary

Enabling https://github.com/bird-house/birdhouse-deploy/tree/master/birdhouse/components/monitoring, and omitting an ALERTMANAGER_SMTP_SERVER variable emits a log error about the missing variable, but doesn't stop the execution as expected.

Details

The following is logged:

ERROR:    Required variable $ALERTMANAGER_SMTP_SERVER is not set. Check env.local file.

But the return 1 from the following does not seem to be triggered (or handled by the calling script?):

birdhouse-deploy/birdhouse/read-configs.include.sh

Lines 337 to 347 in 293645a

	check_required_vars() {
	for i in ${VARS}
	do
	v="${i}"
	if [ -z "`eval "echo ${v}"`" ]
	then
	log ERROR "Required variable $v is not set. Check env.local file."
	return 1
	fi
	done
	}

Maybe this is related to some kind of subshell error catch/forwarding to the caller, similar to what was observed in #509 (comment)

To Reproduce

Steps to reproduce the behavior:

1. Enable the monitoring component (or any other?)
2. Purposely omit some required variable that does not fail the script due to some other cause such as parsing or unresolved reference.
3. Observe that the birdhouse-compose.sh up -d runs until the end without abort.

Environment

any

Concerned Organizations

all

[mishaschwartz]

I can't reproduce this. How exactly are you running this?

This works as expected with any of the following:

bin/birdhouse compose up -d

cd birdhouse && ./birdhouse-compose.sh up -d

cd birdhouse &&  sh birdhouse-compose.sh up -d

I'm running this on ubuntu 24.04

[fmigneault]

Running on Ubuntu 24.04 as well.
I run birdhouse-compose up -d, with birdhouse-compose being a ln -s <path-to>/birdhouse/birdhouse-deploy.sh /usr/bin/birdhouse-compose.

[mishaschwartz]

Ok I set mine up exactly the same... still can't reproduce ... weird.

Do you have a custom environment file path or are you using env.local in the birdhouse directory?

[mishaschwartz]

What flags are set in your shell? What happens when you run echo $- and shopt | grep 'on$'

[fmigneault]

~$ echo $-
himBHs
~$ shopt | grep 'on$'
checkwinsize   	on
cmdhist        	on
complete_fullquote	on
expand_aliases 	on
extglob        	on
extquote       	on
force_fignore  	on
globasciiranges	on
globskipdots   	on
histappend     	on
interactive_comments	on
login_shell    	on
patsub_replacement	on
progcomp       	on
promptvars     	on
sourcepath     	on

[mishaschwartz]

Ok still the same here... are you running the command as root by any chance?

[fmigneault]

No. Running as an unprivileged user that has access to the repository contents.