Security fixes #504
Merged
Security fixes #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlogan2000
approved these changes
Sep 2, 2025
Collaborator
tlogan2000
left a comment
tlogan2000
left a comment
There was a problem hiding this comment.
LGTM assuming you can fix the docker build failure
tlvu
approved these changes
Sep 2, 2025
Collaborator
tlvu
left a comment
tlvu
left a comment
There was a problem hiding this comment.
LGTM, please take a look at my comments.
Collaborator
|
Just to speed up this PR, as long as the github build works, you can merge this PR. If write permission error when added to PAVICS stack, we can fix in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a few security recommendations. The SBOM and provenance adjustment is for testing purposes as the GitHub Workflow doesn't currently push to DockerHub, but once we no longer have Docker autobuild services, we may be using this for production.
Changes:
setuptoolsto address a CWE issuenodefaultssource in conda configurationsnonrootuser for running the Docker serviceRelated Issue / Discussion
Docker Teams Pro subscription is ending in a few weeks. Birdhouse docker images will need to migrate to using the
pushoption indocker/build-push-actionvery soon.