You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am working on being able to sign BitGo multisig vaults with hardware wallets. BitGo uses non-standard derivation paths for their vaults where you provide a master xpub and then they derive addresses from m/0/0/<10;11>/**. (see docs).
Is there a way to make the MultisigWallet class support additional arguments for a custom key_placeholder_suffix?
I think you could take the values of the bip32derivation paths in the global data and then compare/substring them and pass the value into the MultisigWallet constructor.
Alternatively, this functionality could be supported by decoupling the register_wallet functionality from the sign_tx functionality, which would allow for a wallet descriptor to be explicitly passed in which would allow the transaction to be signed when presented (related to #647)
I am working on being able to sign BitGo multisig vaults with hardware wallets. BitGo uses non-standard derivation paths for their vaults where you provide a master xpub and then they derive addresses from
m/0/0/<10;11>/**
. (see docs).In
hwilib/devices/ledger_bitcoin/wallet.py#L117
, thekey_placeholder_suffix
is hardcoded to only support/**
.Is there a way to make the
MultisigWallet
class support additional arguments for a customkey_placeholder_suffix
?I think you could take the values of the bip32derivation paths in the global data and then compare/substring them and pass the value into the
MultisigWallet
constructor.It would probably happen somewhere around hwilib/devices/ledger.py#L265-L291
Alternatively, this functionality could be supported by decoupling the register_wallet functionality from the sign_tx functionality, which would allow for a wallet descriptor to be explicitly passed in which would allow the transaction to be signed when presented (related to #647)
cc @bigspider
Example PSBT
The text was updated successfully, but these errors were encountered: