Use str.splitlines where appropriate

Author: MarcoFalke

backport.py

@@ -72,7 +72,7 @@ class Attr:
 if not execute:
     print('set -e')
 for t in to_backport:
-    msg = t[1].message.rstrip().split('\n')
+    msg = t[1].message.rstrip().splitlines()
     assert(msg[1] == '')
     print('{a.hsh}# {a.head}{}{a.reset}'.format(msg[0],a=Attr))
     # XXX get the commits in the merge from the actual commit data instead of from the commit message

build-for-compare.py

@@ -164,7 +164,7 @@ def objdump_all(srcdir: str, tgtdir: str):
         # postprocess- break into sections separated by 'Disassembly of section...'
         sections = defaultdict(list)
         funcname = ''
-        for line in out.split('\n'):
+        for line in out.splitlines():
             match = re.match('^Disassembly of section (.*):$', line)
             if match:
                 funcname = match.group(1)

github-merge.py

@@ -173,7 +173,7 @@ def get_acks_from_comments(head_commit, comments):
     head_abbrev = head_commit[0:6]
     acks = []
     for c in comments:
-        review = [l for l in c['body'].split('\r\n') if 'ACK' in l and head_abbrev in l]
+        review = [l for l in c['body'].splitlines() if 'ACK' in l and head_abbrev in l]
         if review:
             acks.append((c['user']['login'], review[0]))
     return acks

list-pulls.py

@@ -154,7 +154,7 @@ def remove_last(l):
 # set of all commits
 commits = subprocess.check_output([GIT, 'rev-list', '--reverse', '--topo-order', ref_from+'..'+ref_to])
 commits = commits.decode()
-commits = remove_last(commits.split('\n'))
+commits = remove_last(commits.splitlines())
 commits_list = commits
 commits = set(commits)
 
@@ -166,7 +166,7 @@ def remove_last(l):
     info = subprocess.check_output([GIT, 'show', '-s', '--format=%B%x00%P', commit])
     info = info.decode()
     (message, parents) = info.split('\0')
-    title = message.rstrip().split('\n')[0]
+    title = message.rstrip().splitlines()[0]
     parents = parents.rstrip().split(' ')
     commit_data[commit] = CommitData(commit, message, title, parents)
 
@@ -182,7 +182,7 @@ def parse_commit_message(msg):
     Parse backport commit message.
     '''
     retval = CommitMetaData()
-    for line in msg.split('\n'):
+    for line in msg.splitlines():
         m = re.match('Github-Pull: #?(\d+)', line, re.I)
         if m:
             retval.pull = int(m.group(1))
@@ -210,7 +210,7 @@ def parse_commit_message(msg):
             #print('removing ', c.sha)
             sub_commits = subprocess.check_output([GIT, 'rev-list', c.parents[0]+'..'+c.parents[1]])
             sub_commits = sub_commits.decode()
-            sub_commits = set(sub_commits.rstrip().split('\n'))
+            sub_commits = set(sub_commits.rstrip().splitlines())
             pull = int(match.group(1))
 
             # remove commits that are not in the global list