Tree hash imports argparse, not to use it

[katesalazar]

(and it doesn't handle arguments idiomatically)

Imports argparse:

bitcoin-maintainer-tools/treehash512.py

Line 16 in 961d365

import argparse

Not to use it:

bitcoin-maintainer-tools/treehash512.py

Line 73 in 961d365

if len(sys.argv)>1:

But if I call treehash512.py -h, (almost idiomatic Python?), it'll pass it down (needlessly) to Git ls-tree.

bitcoin-maintainer-tools/treehash512.py

Line 77 in 961d365

print(tree_sha512sum(commit))

I propose you:

• remove the argparse import, or
• use argparse idiomatically, and
  • check argument validity before calling Git

[laanwj]

The command-line functionality is for testing and use in scripts, not meant for end users, would be fine with simply removing the unused import.

[katesalazar]

Then a "remove unused imports" change would remove line 14 too:

bitcoin-maintainer-tools/treehash512.py

Line 14 in 961d365

from sys import stdin,stdout,stderr

Reason is "line 15 is enough":

bitcoin-maintainer-tools/treehash512.py

Line 15 in 961d365

import sys

[laanwj]

Great, feel free to open a PR.