Migrate to PageStacks #428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarolrod
force-pushed
the
pagestack-migration
branch
from
0d7c1ab
to
3788060
Compare
pablomartin4btc
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
tACK 3788060
Nice job! Removing dependencies with ids outside a page was almost mandatory, this avoids unexpected crashes when things change outside the page and can't be noticed. We need to add a hook or a test that evaluates the existence of views we are moving to onNext: and warns if there are components that are not/ (or left un-) referenced.
src/qml/pages/node/NodeSettings.qml
Outdated
Comment on lines
131
to
133
| onBack: { | ||
| nodeSettingsView.pop() | ||
| } |
There was a problem hiding this comment.
nit: as in other places in the same file...
Suggested change
| onBack: { | |
| nodeSettingsView.pop() | |
| } | |
| onBack: nodeSettingsView.pop() |
There was a problem hiding this comment.
a note for the style guide
src/qml/pages/node/NodeSettings.qml
Outdated
Comment on lines
163
to
165
| onBack: { | ||
| nodeSettingsView.pop() | ||
| } |
Introduces a custom PageStack control that is a StackView adapted for our use in terms of the custom animations we demand, and the ability to switch between vertical and horizontal push() and pop(). This can later be further extended for our use cases.
This should be encapsulated so it can be reasoned about independently and in a well defined location. Additionally, swap from SwipeView to PageStack.
Vertical PageStacks used to replace vertical SwipeViews.
jarolrod
force-pushed
the
pagestack-migration
branch
from
3788060
to
c52566d
Compare
MarnixCroes
approved these changes
Nov 12, 2024
D33r-Gee
reviewed
Nov 12, 2024
| SettingsDeveloper { | ||
| onboarding: root.onboarding | ||
| onBack: stack.pop() | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: there are extra blank lines
johnny9
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing our sins in #427, migrating to A StackView based GUI is quite simple.
Here we use a custom StackView control, PageStack, that has a property
verticalused to declare if we want vertical or horizontal animations, and additionally implements the custom animation we want.Closes #422
Closes #219