Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdk_electrum: use transaction-get verbose param #1700

Open
notmandatory opened this issue Nov 14, 2024 · 1 comment
Open

bdk_electrum: use transaction-get verbose param #1700

notmandatory opened this issue Nov 14, 2024 · 1 comment
Labels
audit Suggested as result of external code audit module-blockchain

Comments

@notmandatory
Copy link
Member

"In populate_with_txids you state "because of restrictions of the Electrum API, we have to use the script_get_history call to get confirmation status of our transaction". But Electrum supports a verbose parameter to the transaction.get call, which appears to return the number of confirmations of the transaction. See https://electrumx-spesmilo.readthedocs.io/en/latest/protocol-methods.html#blockchain-transaction-get"

@notmandatory notmandatory added audit Suggested as result of external code audit module-blockchain labels Nov 14, 2024
@notmandatory notmandatory added this to BDK Nov 14, 2024
@notmandatory notmandatory moved this to Discussion in BDK Nov 14, 2024
@LagginTimes
Copy link
Contributor

I ran into a roadblock when looking into and trying to implement this:
Blockstream/electrs#36
Blockstream electrs does not yet support the verbose feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit Suggested as result of external code audit module-blockchain
Projects
Status: Discussion
Development

No branches or pull requests

2 participants