Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cert4android] Move cert4android UI tasks to app #1331

Open
rfc2822 opened this issue Mar 1, 2025 · 2 comments
Open

[cert4android] Move cert4android UI tasks to app #1331

rfc2822 opened this issue Mar 1, 2025 · 2 comments
Labels
dependent refactoring Internal improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Mar 1, 2025 •
edited by sunkup
Loading

Right now, when a users decision on whether to trust a certificate is needed, cert4android will show TrustCertificateActivity and/or a notification if it's allowed to. This is error prone (see #1313) so we want to move the responsibility of showing a notification and/or the certificate trust decision dialog to DAVx5.

Will likely also fix: #861 (reply in thread)

--
Depends on bitfireAT/cert4android#49
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2025

This PR/issue depends on:

@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Mar 1, 2025
@rfc2822
Copy link
Member Author

rfc2822 commented Mar 6, 2025

We should also better handle the customCerts[Ui] build flag: if it's false, we should immediately reject questionable certificates.

Guess it would be better to have an option for that in cert4android?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependent refactoring Internal improvement of existing functions
Projects
DAVx⁵ Releases
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rfc2822