Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send max rounds down a few sats when using fiat amount #5585

Open
ben-kaufman opened this issue Nov 13, 2024 · 0 comments
Open

Send max rounds down a few sats when using fiat amount #5585

ben-kaufman opened this issue Nov 13, 2024 · 0 comments
Assignees
@ben-kaufman
Labels
bug🐛 did not exist in previous release but now it is. S&R↔️ Send, receive, balance fetch, UTXOs Status: fixed✅ It is fixed (PR merged)
Milestone
Sprint 40

Comments

@ben-kaufman
Copy link
Contributor

Send max with fiat rounds down the last cent, we should treat send max as a "special case" to select the full sats amount even when it's not a "whole" cent.
@ben-kaufman ben-kaufman added S&R↔️ Send, receive, balance fetch, UTXOs Status: In peer review 👀 PR raised (with reviewer assigned) bug🐛 did not exist in previous release but now it is. labels Nov 13, 2024
@ben-kaufman ben-kaufman self-assigned this Nov 13, 2024
@ben-kaufman ben-kaufman mentioned this issue Nov 13, 2024
Merged
@ben-kaufman ben-kaufman added this to the Sprint 40 milestone Nov 13, 2024
@ben-kaufman ben-kaufman added Status: fixed✅ It is fixed (PR merged) and removed Status: In peer review 👀 PR raised (with reviewer assigned) labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben-kaufman ben-kaufman

Labels
bug🐛 did not exist in previous release but now it is. S&R↔️ Send, receive, balance fetch, UTXOs Status: fixed✅ It is fixed (PR merged)
Projects
None yet
Milestone
Sprint 40
Development

No branches or pull requests
1 participant
@ben-kaufman