Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fee is calculated incorrectly #5594

Open
ben-kaufman opened this issue Nov 15, 2024 · 0 comments
Open

Fee is calculated incorrectly #5594

ben-kaufman opened this issue Nov 15, 2024 · 0 comments
Assignees
@ben-kaufman
Labels
bug🐛 did not exist in previous release but now it is. S&R↔️ Send, receive, balance fetch, UTXOs Status: In peer review 👀 PR raised (with reviewer assigned)
Milestone
Sprint 40

Comments

@ben-kaufman
Copy link
Contributor

The fee calculation is using the coinselect library, which uses bytes instead of vbytes for the fee rate, making the fee calculation result in about 2x too much fee.

Also, the send max is overestimating the fee, resulting in too much fee being paid.
@ben-kaufman ben-kaufman added S&R↔️ Send, receive, balance fetch, UTXOs Status: In peer review 👀 PR raised (with reviewer assigned) bug🐛 did not exist in previous release but now it is. labels Nov 15, 2024
@ben-kaufman ben-kaufman self-assigned this Nov 15, 2024
@ben-kaufman ben-kaufman added this to the Sprint 40 milestone Nov 15, 2024
@ben-kaufman ben-kaufman mentioned this issue Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben-kaufman ben-kaufman

Labels
bug🐛 did not exist in previous release but now it is. S&R↔️ Send, receive, balance fetch, UTXOs Status: In peer review 👀 PR raised (with reviewer assigned)
Projects
None yet
Milestone
Sprint 40
Development

No branches or pull requests
1 participant
@ben-kaufman