Skip to content

Commit a7b6665

Browse files
factions-user
f
authored andcommitted
ignore package jsons in biome since changesets modifies it
GitOrigin-RevId: 7335f6b547bac36260f96ec397a7df1f2046c064
1 parent f0b3418 commit a7b6665

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

Diff for: .github/workflows/packages.react-router-busy.release.yml

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ on:
66
branches:
77
- main
88
paths:
9+
# This is fine for merging PR which is a push to main because changesets updates package's changelog and package.json to trigger this
910
- 'packages/react-router-busy/**'
1011

1112
# Don't run publish multiple times at once

Diff for: biome.jsonc

+4-2
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,12 @@
3030
"formatter": {
3131
"ignore": [
3232
// Until we fix vite-plugin-icons-spritesheet
33-
"./apps/git-sell/public/icons/*"
33+
"./apps/git-sell/public/icons/*",
3434
// Until biome handles nested gitignore files
3535
// Actually not tracked in git so doesn't matter
36-
// "./packages/react-router-busy/dist/*"
36+
// "./packages/react-router-busy/dist/*",
37+
// changesets changes package json formatting causing lint failure before publish
38+
"**/package.json"
3739
]
3840
},
3941
"vcs": {

Diff for: packages/react-router-busy/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,4 +60,4 @@ return (
6060

6161
### NavLink
6262

63-
TODO Better not to have all that extra code for the `as` prop.
63+
TODO Better not to have all that extra code for the `as` prop

0 commit comments

Comments
 (0)