ignore package jsons in biome since changesets modifies it

GitOrigin-RevId: 7335f6b547bac36260f96ec397a7df1f2046c064
bitofbreeze · Sep 19, 2024 · a7b6665 · a7b6665
1 parent f0b3418
commit a7b6665
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/packages.react-router-busy.release.yml b/.github/workflows/packages.react-router-busy.release.yml
@@ -6,6 +6,7 @@ on:
     branches:
       - main
     paths:
+      # This is fine for merging PR which is a push to main because changesets updates package's changelog and package.json to trigger this
       - 'packages/react-router-busy/**'
 
 # Don't run publish multiple times at once

diff --git a/biome.jsonc b/biome.jsonc
@@ -30,10 +30,12 @@
 	"formatter": {
 		"ignore": [
 			// Until we fix vite-plugin-icons-spritesheet
-			"./apps/git-sell/public/icons/*"
+			"./apps/git-sell/public/icons/*",
 			// Until biome handles nested gitignore files
 			// Actually not tracked in git so doesn't matter
-			// "./packages/react-router-busy/dist/*"
+			// "./packages/react-router-busy/dist/*",
+			// changesets changes package json formatting causing lint failure before publish
+			"**/package.json"
 		]
 	},
 	"vcs": {

diff --git a/packages/react-router-busy/README.md b/packages/react-router-busy/README.md
@@ -60,4 +60,4 @@ return (
 
 ### NavLink
 
-TODO Better not to have all that extra code for the `as` prop.
+TODO Better not to have all that extra code for the `as` prop
Original file line number	Diff line number	Diff line change
Expand Up		@@ -60,4 +60,4 @@ return (

		### NavLink

		TODO Better not to have all that extra code for the `as` prop.
		TODO Better not to have all that extra code for the `as` prop