String deriviation paths cause invalid hardening value due to Lodash call

[SmartArray]

We found a flaw with the string typed key derivation function at the following call:

bitcore/packages/bitcore-lib/lib/hdprivatekey.js

Lines 74 to 78 in bed0702

	HDPrivateKey.isValidPath = function(arg, hardened) {
	if (_.isString(arg)) {
	var indexes = HDPrivateKey._getDerivationIndexes(arg);
	return indexes !== null && _.every(indexes, HDPrivateKey.isValidPath);
	}

_.every calls the function HDPrivateKey.isValidPath with two args:

1. The first arg is the expected parsed number of the derivation path
2. The second (unexpected) arg is the index of the root array which toggles the hardening parameter of the function (isValidPath), which is clearly unintended

An easy fix is to introduce an anonymous function as shown in this PR: #3359

[kajoseph]

Thanks for reporting and the PR, @SmartArray. I am looking at this now

[kajoseph]

@SmartArray Just so I'm clear, you are not having any issues with the outcome of isValidPath, correct? The strict check for hardened === true in the line below ensures that passing in the array index via _.every doesn't have an effect.

bitcore/packages/bitcore-lib/lib/hdprivatekey.js

Line 81 in 2694f72

if (arg < HDPrivateKey.Hardened && hardened === true) {

If this is "just" a code smell issue (read: not imminently urgent), then we'll want to reconcile #3359 with #3350. The same issue exists, but will inevitably result in merge conflicts between the two.