-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-11612] Use SchedulerBuilder to configure Quartz #4729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
…z-strongly-typed-configuration
|
Great job! No new security vulnerabilities introduced in this pull request |
djsmith85
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lahma Thank you for your contribution 🎉 Your changes are looking good and greatly simplify the setup. I went ahead and updated the branch from main and fixed any conflicts. I'm requesting a review from @dani-garcia regarding my changes made here.
Thanks again for your contribution, but more importantly for creating such a great library as Quartz.net 🙌 ❤️
Kind regards,
Daniel
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4729 +/- ##
==========================================
- Coverage 53.28% 53.27% -0.01%
==========================================
Files 1906 1906
Lines 84973 84972 -1
Branches 7639 7640 +1
==========================================
- Hits 45275 45272 -3
- Misses 37944 37945 +1
- Partials 1754 1755 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dani-garcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks!

🎟️ Tracking
Checking use of error-prone configuration property usage instead of using strongly-typed builder.
📔 Objective
Quartz has
SchedulerBuilderAPI which hides nasty configuration string properties.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes