Skip to content

Conversation

@lahma
Copy link

@lahma lahma commented Sep 3, 2024

🎟️ Tracking

Checking use of error-prone configuration property usage instead of using strongly-typed builder.

📔 Objective

Quartz has SchedulerBuilder API which hides nasty configuration string properties.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-11612

@bitwarden-bot bitwarden-bot changed the title Use SchedulerBuilder t configure Quartz [PM-11612] Use SchedulerBuilder t configure Quartz Sep 3, 2024
@djsmith85 djsmith85 requested review from a team and dani-garcia November 21, 2025 15:38
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Logo
Checkmarx One – Scan Summary & Detailsad46a71c-4f40-448c-b24a-f58280611a0d

Great job! No new security vulnerabilities introduced in this pull request

@djsmith85 djsmith85 self-assigned this Nov 28, 2025
Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lahma Thank you for your contribution 🎉 Your changes are looking good and greatly simplify the setup. I went ahead and updated the branch from main and fixed any conflicts. I'm requesting a review from @dani-garcia regarding my changes made here.

Thanks again for your contribution, but more importantly for creating such a great library as Quartz.net 🙌 ❤️

Kind regards,
Daniel

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.27%. Comparing base (3ad4860) to head (f017479).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Core/Jobs/BaseJobsHostedService.cs 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4729      +/-   ##
==========================================
- Coverage   53.28%   53.27%   -0.01%     
==========================================
  Files        1906     1906              
  Lines       84973    84972       -1     
  Branches     7639     7640       +1     
==========================================
- Hits        45275    45272       -3     
- Misses      37944    37945       +1     
- Partials     1754     1755       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trmartin4 trmartin4 changed the title [PM-11612] Use SchedulerBuilder t configure Quartz [PM-11612] Use SchedulerBuilder to configure Quartz Dec 1, 2025
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants