-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Aspirification of API service (incl admin + identity dbs) #5902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: David Fowler <[email protected]> Co-authored-by: Damian Edwards <[email protected]> Co-authored-by: Glenn Condron <[email protected]>
|
Awesome stuff! Thanks for working on this today, and with us. We have a lot brewing over at https://github.com/bitwarden/dotnet-extensions and we might be able to bring a number of these startup changes in when we finish its introduction into our monolith here. |
@@ -1,6 +1,6 @@ | |||
{ | |||
"sdk": { | |||
"version": "8.0.100", | |||
"version": "9.0.100", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 @justindbaur, @withinfocus - Wanted to draw your attention to this. I'm not sure who owns the .Net SDK dependency, but it looks like it needs to update before we merge this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, and we are currently planning on just jumping to 10. We'll see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Auth changes are simple
🎟️ Tracking
n/a
📔 Objective
Aspire orchestration for bitwarden/server
📸 Screenshots
https://www.youtube.com/watch?v=UjQ-fVkwqpY
⏰ Reminders before review
I haven't done any of these sorry 😂
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes