Skip to content

[PM-22205] Fix logic for sending out revoked email #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JimmyVo16
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22205

📔 Objective

Root cause: We accidentally used the wrong variable for sending out the revoked emails, causing every user member to receive an email instead of just the revoked users.

Changes

  1. Use the correct variable.
  2. Update the unit test to assert that only the revoked users receive the email.

📸 Screenshots

The updated unit test should cover this, but here is a manual test to confirm the behavior.

Manual.testing.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@JimmyVo16 JimmyVo16 self-assigned this Jun 6, 2025
@JimmyVo16 JimmyVo16 requested a review from a team as a code owner June 6, 2025 15:46
@JimmyVo16 JimmyVo16 requested a review from r-tome June 6, 2025 15:46
Copy link

sonarqubecloud bot commented Jun 6, 2025

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.73%. Comparing base (dcf97a5) to head (d058b68).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5933   +/-   ##
=======================================
  Coverage   47.73%   47.73%           
=======================================
  Files        1665     1665           
  Lines       75022    75022           
  Branches     6757     6757           
=======================================
  Hits        35811    35811           
  Misses      37751    37751           
  Partials     1460     1460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 6, 2025

Logo
Checkmarx One – Scan Summary & Details19828e42-248a-4817-bcf5-43e12889761f

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants