Skip to content

Conversation

@eliykat
Copy link
Member

@eliykat eliykat commented Dec 3, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28487

📔 Objective

Update code ownership of Events and EventsProcessor projects to the Data Insights and Reporting Team (DIRT), as the new owners of the organization events domain.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@eliykat eliykat requested a review from ttalty December 3, 2025 04:09
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.63%. Comparing base (acc2529) to head (291b830).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6678      +/-   ##
==========================================
- Coverage   53.63%   53.63%   -0.01%     
==========================================
  Files        1926     1926              
  Lines       85717    85711       -6     
  Branches     7686     7686              
==========================================
- Hits        45978    45974       -4     
+ Misses      37966    37964       -2     
  Partials     1773     1773              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Logo
Checkmarx One – Scan Summary & Detailsa716a904-fadb-4a77-8934-e25ef0be4506

Fixed Issues (5)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 507
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 97
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 207
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 87
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 97

@claude
Copy link
Contributor

claude bot commented Dec 8, 2025

Claude finished @eliykat's task —— View job


Code Review Complete ✅

Tasks

  • Gather context and read changed files
  • Review PR changes using bitwarden-code-reviewer agent
  • Post comprehensive review feedback

Review Feedback

Overall Assessment: ✅ APPROVE

This PR correctly transfers ownership of the Events and EventsProcessor projects from the Admin Console team to the DIRT (Data Insights & Reporting) team.

What was reviewed:

  • Changes to .github/CODEOWNERS file
  • Ownership transfer from @bitwarden/team-admin-console-dev to @bitwarden/team-data-insights-and-reporting-dev

✅ Correct Implementation:

  1. Source directories properly transferred:

    • src/Events → DIRT team
    • src/EventsProcessor → DIRT team
  2. Test coverage included:

    • test/Events.IntegrationTest → DIRT team
    • test/Events.Test → DIRT team
    • test/EventsProcessor.Test → DIRT team
  3. File organization:

    • Entries correctly removed from Admin Console section (lines 66-67 removed)
    • Entries correctly added to DIRT section (lines 56-60 added)
    • Alphabetical ordering maintained within the DIRT team group per file guidelines
    • All specified paths exist in the repository ✓

Summary:

The ownership transfer is complete and correct. All relevant source and test directories are included, and the file maintains proper organization and sorting conventions. No issues found.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants