-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-28485] Move organization events domain to DIRT code ownership #6685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[PM-28485] Move organization events domain to DIRT code ownership #6685
Conversation
|
Claude finished @eliykat's task —— View job Code Review Complete ✅Tasks
Review SummaryOverall Assessment: ✅ APPROVE This PR successfully moves organization events domain code to DIRT team ownership by relocating 52 files from Strengths👍 Clean file organization: All event-related files (API controllers, models, entities, repositories, services, SQL objects, and tests) have been systematically moved to the appropriate 👍 Appropriate scope boundaries:
👍 Consistent structure: The moves cover all layers:
👍 CODEOWNERS alignment: The existing Design Decision Notesℹ️ Namespace preservation strategy: Per the PR description, namespaces have intentionally NOT been updated (except API layer) to minimize impact through the codebase. This is a pragmatic approach that:
The only namespace changes are in the API layer ( Minor Observations📝 Interface location: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6685 +/- ##
==========================================
+ Coverage 53.63% 57.46% +3.82%
==========================================
Files 1926 1926
Lines 85717 85717
Branches 7686 7686
==========================================
+ Hits 45978 49254 +3276
+ Misses 37966 34617 -3349
- Partials 1773 1846 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…o-dirt-team-folders
|
|
|
We have some larger changes still coming in with our caching work so looking at this right now gives me some pause. |
…o-dirt-team-folders


🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-28485
📔 Objective
Move code relating to organization events into DIRT code ownership.
Intentionally excluded:
Namespaces have generally not been updated in order to minimize impact through the codebase.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes